From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2] gfs:remove a warning in gfs2_lookup_by_inum()
Date: Wed, 13 Apr 2011 11:11:55 +0100 [thread overview]
Message-ID: <1302689515.2613.5.camel@dolmen> (raw)
In-Reply-To: <1302489770-31552-1-git-send-email-panweiping3@gmail.com>
Hi,
Thanks for the patch, however a fix for this is already in the GFS2 -nmw
git tree,
Steve.
On Mon, 2011-04-11 at 10:42 +0800, Weiping Pan(???) wrote:
> /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c: In function
> ?gfs2_lookup_by_inum?: /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c:188:16:
> warning: ?inode? may be used uninitialized in this function
>
> Signed-off-by: Weiping Pan(???) <panweiping3@gmail.com>
> ---
> fs/gfs2/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 97d54a2..5b937c6 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -185,7 +185,7 @@ struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
> {
> struct super_block *sb = sdp->sd_vfs;
> struct gfs2_holder i_gh;
> - struct inode *inode;
> + struct inode *inode = NULL;
> int error;
>
> error = gfs2_glock_nq_num(sdp, no_addr, &gfs2_inode_glops,
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: "Weiping Pan(潘卫平)" <panweiping3@gmail.com>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gfs:remove a warning in gfs2_lookup_by_inum()
Date: Wed, 13 Apr 2011 11:11:55 +0100 [thread overview]
Message-ID: <1302689515.2613.5.camel@dolmen> (raw)
In-Reply-To: <1302489770-31552-1-git-send-email-panweiping3@gmail.com>
Hi,
Thanks for the patch, however a fix for this is already in the GFS2 -nmw
git tree,
Steve.
On Mon, 2011-04-11 at 10:42 +0800, Weiping Pan(潘卫平) wrote:
> /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c: In function
> ‘gfs2_lookup_by_inum’: /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c:188:16:
> warning: ‘inode’ may be used uninitialized in this function
>
> Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
> ---
> fs/gfs2/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 97d54a2..5b937c6 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -185,7 +185,7 @@ struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
> {
> struct super_block *sb = sdp->sd_vfs;
> struct gfs2_holder i_gh;
> - struct inode *inode;
> + struct inode *inode = NULL;
> int error;
>
> error = gfs2_glock_nq_num(sdp, no_addr, &gfs2_inode_glops,
next prev parent reply other threads:[~2011-04-13 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 2:42 [PATCH 1/2] gfs:remove a warning in gfs2_lookup_by_inum() Weiping Pan(潘卫平)
2011-04-13 10:11 ` Steven Whitehouse [this message]
2011-04-13 10:11 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302689515.2613.5.camel@dolmen \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.