From: Artem Bityutskiy <dedekind1@gmail.com>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Dima Zavin" <dima@android.com>,
"Brian Swetland" <swetland@google.com>,
"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Sat, 16 Apr 2011 17:19:50 +0300 [thread overview]
Message-ID: <1302963590.2308.9.camel@koala> (raw)
In-Reply-To: <4DA96890.2070207@codeaurora.org>
> Can i export this variable now?
I do not think so, we do not export random variables.
> What is your suggestion?
But I already did provide you suggestions - kill this global variable
completely. I provided the reasons:
1. It is error prone to hide functions behind something which looks like
a constant.
2. Multiple controllers with different base addresses wouldn't work -
your driver has to be able to at least theoretically handle multiple
controllers with different bases.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dima Zavin" <dima@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
linux-mtd@lists.infradead.org,
"Brian Swetland" <swetland@google.com>,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Sat, 16 Apr 2011 17:19:50 +0300 [thread overview]
Message-ID: <1302963590.2308.9.camel@koala> (raw)
In-Reply-To: <4DA96890.2070207@codeaurora.org>
> Can i export this variable now?
I do not think so, we do not export random variables.
> What is your suggestion?
But I already did provide you suggestions - kill this global variable
completely. I provided the reasons:
1. It is error prone to hide functions behind something which looks like
a constant.
2. Multiple controllers with different base addresses wouldn't work -
your driver has to be able to at least theoretically handle multiple
controllers with different bases.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Sat, 16 Apr 2011 17:19:50 +0300 [thread overview]
Message-ID: <1302963590.2308.9.camel@koala> (raw)
In-Reply-To: <4DA96890.2070207@codeaurora.org>
> Can i export this variable now?
I do not think so, we do not export random variables.
> What is your suggestion?
But I already did provide you suggestions - kill this global variable
completely. I provided the reasons:
1. It is error prone to hide functions behind something which looks like
a constant.
2. Multiple controllers with different base addresses wouldn't work -
your driver has to be able to at least theoretically handle multiple
controllers with different bases.
--
Best Regards,
Artem Bityutskiy (???????? ?????)
next prev parent reply other threads:[~2011-04-16 14:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 0:47 [PATCH 1/2] mtd: nand: Allow NAND chip ids to be included standalone Murali Nalajala
2011-03-01 0:47 ` Murali Nalajala
2011-03-01 0:47 ` Murali Nalajala
2011-03-01 0:47 ` [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support Murali Nalajala
2011-07-08 18:23 ` Murali Nalajala
2011-03-01 0:47 ` Murali Nalajala
2011-03-01 0:47 ` Murali Nalajala
2011-04-15 9:51 ` Artem Bityutskiy
2011-07-08 16:03 ` Artem Bityutskiy
2011-04-15 9:51 ` Artem Bityutskiy
2011-04-15 14:50 ` Murali Nalajala
2011-04-15 14:50 ` Murali Nalajala
2011-04-15 14:50 ` Murali Nalajala
2011-04-16 8:20 ` Artem Bityutskiy
2011-04-16 8:20 ` Artem Bityutskiy
2011-04-16 8:20 ` Artem Bityutskiy
2011-04-16 8:31 ` Artem Bityutskiy
2011-04-16 8:31 ` Artem Bityutskiy
2011-04-16 8:31 ` Artem Bityutskiy
2011-04-16 10:15 ` Murali Nalajala
2011-04-16 10:15 ` Murali Nalajala
2011-04-16 10:15 ` Murali Nalajala
2011-04-16 9:59 ` Murali Nalajala
2011-04-16 9:59 ` Murali Nalajala
2011-04-16 9:59 ` Murali Nalajala
2011-04-16 14:19 ` Artem Bityutskiy [this message]
2011-04-16 14:19 ` Artem Bityutskiy
2011-04-16 14:19 ` Artem Bityutskiy
2011-03-07 8:53 ` [PATCH 1/2] mtd: nand: Allow NAND chip ids to be included standalone Artem Bityutskiy
2011-03-07 8:53 ` Artem Bityutskiy
2011-03-07 8:53 ` Artem Bityutskiy
2011-03-07 8:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302963590.2308.9.camel@koala \
--to=dedekind1@gmail.com \
--cc=arve@android.com \
--cc=dima@android.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mnalajal@codeaurora.org \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.