All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Raghavendra D Prabhu <rprabhu@wnohang.net>
Cc: linux-mm@kvack.org, Jens Axboe <jaxboe@fusionio.com>,
	Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Add check for dirty_writeback_interval in bdi_wakeup_thread_delayed
Date: Mon, 18 Apr 2011 15:26:29 +0300	[thread overview]
Message-ID: <1303129589.8589.5.camel@localhost> (raw)
In-Reply-To: <20110418091609.GC5143@Xye>

On Mon, 2011-04-18 at 14:46 +0530, Raghavendra D Prabhu wrote:
> I have set it to 500 centisecs as that is the default value of
> dirty_writeback_interval. I used this logic for following reason: the
> purpose for which dirty_writeback_interval is set to 0 is to disable
> periodic writeback
> (http://tomoyo.sourceforge.jp/cgi-bin/lxr/source/fs/fs-writeback.c#L818)
> , whereas here (in bdi_wakeup_thread_delayed) it is being used for a
> different purpose -- to delay the bdi wakeup in order to reduce context
> switches for  dirty inode writeback.

But why it wakes up the bdi thread? Exactly to make sure the periodic
write-back happen.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Raghavendra D Prabhu <rprabhu@wnohang.net>
Cc: linux-mm@kvack.org, Jens Axboe <jaxboe@fusionio.com>,
	Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Add check for dirty_writeback_interval in bdi_wakeup_thread_delayed
Date: Mon, 18 Apr 2011 15:26:29 +0300	[thread overview]
Message-ID: <1303129589.8589.5.camel@localhost> (raw)
In-Reply-To: <20110418091609.GC5143@Xye>

On Mon, 2011-04-18 at 14:46 +0530, Raghavendra D Prabhu wrote:
> I have set it to 500 centisecs as that is the default value of
> dirty_writeback_interval. I used this logic for following reason: the
> purpose for which dirty_writeback_interval is set to 0 is to disable
> periodic writeback
> (http://tomoyo.sourceforge.jp/cgi-bin/lxr/source/fs/fs-writeback.c#L818)
> , whereas here (in bdi_wakeup_thread_delayed) it is being used for a
> different purpose -- to delay the bdi wakeup in order to reduce context
> switches for  dirty inode writeback.

But why it wakes up the bdi thread? Exactly to make sure the periodic
write-back happen.

-- 
Best Regards,
Artem Bityutskiy (D?N?N?N?D 1/4  D?D,N?N?N?DoD,D1)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-04-18 12:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17 16:23 [PATCH 1/1] Add check for dirty_writeback_interval in bdi_wakeup_thread_delayed Raghavendra D Prabhu
2011-04-17 16:23 ` Raghavendra D Prabhu
2011-04-18  0:02 ` Dave Chinner
2011-04-18  0:02   ` Dave Chinner
2011-04-18  7:08   ` [TOME] " Raghavendra D Prabhu
2011-04-18  7:19 ` Artem Bityutskiy
2011-04-18  7:19   ` Artem Bityutskiy
2011-04-18  9:16   ` Raghavendra D Prabhu
2011-04-18 12:26     ` Artem Bityutskiy [this message]
2011-04-18 12:26       ` Artem Bityutskiy
2011-04-20 19:17       ` Raghavendra D Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303129589.8589.5.camel@localhost \
    --to=artem.bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rprabhu@wnohang.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.