All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: ext Christoph Lameter <cl@linux.com>,
	akpm@linux-foundation.org, aarcange@redhat.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: make read-only accessors take const parameters
Date: Wed, 20 Apr 2011 14:45:19 +0300	[thread overview]
Message-ID: <1303299919.2700.26.camel@localhost> (raw)
In-Reply-To: <20110415160701.GE7112@esdhcp04044.research.nokia.com>

On Fri, 2011-04-15 at 19:07 +0300, Phil Carmody wrote:
> Not in C, alas. As it returns what it's given I wouldn't want it to
> lie
> about the type of what it returns, and some of its clients want it to
> return something writeable. 

I think this little lie is prettier than _ro variants of functions. I do
not think you'll go far with your 'const' quest if you start adding _ro
variants for different core functions, but if you just cast the return
pointer to non-const you might be more successful.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)


WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: ext Christoph Lameter <cl@linux.com>,
	akpm@linux-foundation.org, aarcange@redhat.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: make read-only accessors take const parameters
Date: Wed, 20 Apr 2011 14:45:19 +0300	[thread overview]
Message-ID: <1303299919.2700.26.camel@localhost> (raw)
In-Reply-To: <20110415160701.GE7112@esdhcp04044.research.nokia.com>

On Fri, 2011-04-15 at 19:07 +0300, Phil Carmody wrote:
> Not in C, alas. As it returns what it's given I wouldn't want it to
> lie
> about the type of what it returns, and some of its clients want it to
> return something writeable. 

I think this little lie is prettier than _ro variants of functions. I do
not think you'll go far with your 'const' quest if you start adding _ro
variants for different core functions, but if you just cast the return
pointer to non-const you might be more successful.

-- 
Best Regards,
Artem Bityutskiy (D?N?N?N?D 1/4  D?D,N?N?N?DoD,D1)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-04-20 11:48 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15  9:56 [PATCH 0/1] mm: make read-only accessors take const pointer parameters Phil Carmody
2011-04-15  9:56 ` Phil Carmody
2011-04-15  9:56 ` [PATCH] mm: make read-only accessors take const parameters Phil Carmody
2011-04-15  9:56   ` Phil Carmody
2011-04-15 14:51   ` Christoph Lameter
2011-04-15 14:51     ` Christoph Lameter
2011-04-15 16:07     ` Phil Carmody
2011-04-15 16:07       ` Phil Carmody
2011-04-20 11:45       ` Artem Bityutskiy [this message]
2011-04-20 11:45         ` Artem Bityutskiy
2011-04-16 23:48   ` David Rientjes
2011-04-16 23:48     ` David Rientjes
2011-04-15 14:51 ` [PATCH 0/1] mm: make read-only accessors take const pointer parameters Andrea Arcangeli
2011-04-15 14:51   ` Andrea Arcangeli
2011-04-15 15:59   ` Phil Carmody
2011-04-15 15:59     ` Phil Carmody
2011-04-15 16:09     ` Andrea Arcangeli
2011-04-15 16:09       ` Andrea Arcangeli
2011-04-20  9:28       ` Artem Bityutskiy
2011-04-20  9:28         ` Artem Bityutskiy
2011-04-20 11:20         ` Michal Nazarewicz
2011-04-20 11:20           ` Michal Nazarewicz
2011-04-20 11:44           ` Artem Bityutskiy
2011-04-20 11:44             ` Artem Bityutskiy
2011-04-15 16:12     ` Michal Nazarewicz
2011-04-15 16:12       ` Michal Nazarewicz
2011-04-15 16:28       ` Phil Carmody
2011-04-15 16:28         ` Phil Carmody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303299919.2700.26.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.