All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andreas Dilger <adilger@dilger.ca>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>, xfs <xfs@oss.sgi.com>,
	jack <jack@suse.cz>, axboe <axboe@kernel.dk>,
	dchinner <dchinner@redhat.com>
Subject: Re: buffered writeback torture program
Date: Thu, 21 Apr 2011 14:29:37 -0400	[thread overview]
Message-ID: <1303410534-sup-6933@think> (raw)
In-Reply-To: <20110421180805.GA2627@infradead.org>

Excerpts from Christoph Hellwig's message of 2011-04-21 14:08:05 -0400:
> On Thu, Apr 21, 2011 at 02:02:43PM -0400, Chris Mason wrote:
> > For this program, they are almost all dirty pages.
> > 
> > I tried patching it to give up if we seek but it is still pretty slow.
> > There's something else going on in addition to the xfs clustering being
> > too aggressive.
> 
> I'm not sure where you this beeing to agressive from - it's doing
> exactly the same amount of I/O as a filesystem writing out a single
> page from ->writepage or using write_cache_pages (either directly
> or as a copy) as ->writepages.  The only thing special compared to
> the no ->writepages case is that it's submitting a large I/O
> from the first ->writepage call.
> 

Ok, I see what you mean.  The clustering code stops once it hits
nr_to_write, I missed that.  So we shouldn't be doing more than a single
writepages call.

-chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andreas Dilger <adilger@dilger.ca>, axboe <axboe@kernel.dk>,
	jack <jack@suse.cz>, xfs <xfs@oss.sgi.com>,
	dchinner <dchinner@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: buffered writeback torture program
Date: Thu, 21 Apr 2011 14:29:37 -0400	[thread overview]
Message-ID: <1303410534-sup-6933@think> (raw)
In-Reply-To: <20110421180805.GA2627@infradead.org>

Excerpts from Christoph Hellwig's message of 2011-04-21 14:08:05 -0400:
> On Thu, Apr 21, 2011 at 02:02:43PM -0400, Chris Mason wrote:
> > For this program, they are almost all dirty pages.
> > 
> > I tried patching it to give up if we seek but it is still pretty slow.
> > There's something else going on in addition to the xfs clustering being
> > too aggressive.
> 
> I'm not sure where you this beeing to agressive from - it's doing
> exactly the same amount of I/O as a filesystem writing out a single
> page from ->writepage or using write_cache_pages (either directly
> or as a copy) as ->writepages.  The only thing special compared to
> the no ->writepages case is that it's submitting a large I/O
> from the first ->writepage call.
> 

Ok, I see what you mean.  The clustering code stops once it hits
nr_to_write, I missed that.  So we shouldn't be doing more than a single
writepages call.

-chris

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-04-21 18:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20 18:23 buffered writeback torture program Chris Mason
2011-04-20 18:23 ` Chris Mason
2011-04-20 22:06 ` Vivek Goyal
2011-04-20 22:06   ` Vivek Goyal
2011-04-21 11:09   ` Chris Mason
2011-04-21 11:09     ` Chris Mason
2011-04-21 15:25     ` Chris Mason
2011-04-21 15:25       ` Chris Mason
2011-04-21 15:35       ` Vivek Goyal
2011-04-21 15:35         ` Vivek Goyal
2011-04-21 16:55       ` Jan Kara
2011-04-21 16:55         ` Jan Kara
2011-04-21 16:57         ` Chris Mason
2011-04-21 16:57           ` Chris Mason
2011-04-21 20:44           ` Jan Kara
2011-04-21 20:44             ` Jan Kara
2011-04-21  8:32 ` Christoph Hellwig
2011-04-21  8:32   ` Christoph Hellwig
2011-04-21 17:34   ` Chris Mason
2011-04-21 17:34     ` Chris Mason
2011-04-21 17:41     ` Christoph Hellwig
2011-04-21 17:41       ` Christoph Hellwig
2011-04-21 17:59       ` Andreas Dilger
2011-04-21 17:59         ` Andreas Dilger
2011-04-21 18:02         ` Christoph Hellwig
2011-04-21 18:02           ` Christoph Hellwig
2011-04-21 18:02           ` Chris Mason
2011-04-21 18:02             ` Chris Mason
2011-04-21 18:08             ` Christoph Hellwig
2011-04-21 18:08               ` Christoph Hellwig
2011-04-21 18:29               ` Chris Mason [this message]
2011-04-21 18:29                 ` Chris Mason
2011-04-21 18:43                 ` Andreas Dilger
2011-04-21 18:43                   ` Andreas Dilger
2011-04-21 18:47                   ` Chris Mason
2011-04-21 18:47                     ` Chris Mason
2011-04-21 18:00       ` Chris Mason
2011-04-21 18:00         ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1303410534-sup-6933@think \
    --to=chris.mason@oracle.com \
    --cc=adilger@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=dchinner@redhat.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.