From: Johannes Berg <johannes@sipsolutions.net>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger
Date: Sun, 24 Apr 2011 20:38:26 +0200 [thread overview]
Message-ID: <1303670306.3603.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1303665300-1775-1-git-send-email-wey-yi.w.guy@intel.com> (sfid-20110424_191812_851726_8A7D5FAA)
On Sun, 2011-04-24 at 10:15 -0700, Wey-Yi Guy wrote:
> The current led blink trigger implementaion assume on/off time are equal,
> it works but not have any flexbile for different blink pattern.
>
> Add "ratio" parameter in the trigger table and give driver more control
> on how the on/off blink time behavior should be.
I considered this when writing the original code, but then decided that
nobody needed to have unequal on/off times. Why would we need it now?
(FWIW, blink = 0 is always on already, no?)
johannes
next prev parent reply other threads:[~2011-04-24 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 17:15 [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger Wey-Yi Guy
2011-04-24 18:38 ` Johannes Berg [this message]
2011-04-24 18:48 ` wwguy
2011-04-24 19:29 ` Johannes Berg
2011-04-24 19:37 ` wwguy
2011-04-24 19:44 ` Johannes Berg
2011-04-24 19:49 ` wwguy
2011-04-25 7:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303670306.3603.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.