From: Johannes Berg <johannes@sipsolutions.net>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>
Subject: Re: [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger
Date: Sun, 24 Apr 2011 21:44:58 +0200 [thread overview]
Message-ID: <1303674298.3603.9.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1303673834.22777.15.camel@wwguy-ubuntu>
On Sun, 2011-04-24 at 12:37 -0700, wwguy wrote:
> > So if you want "solid on" by default for 0 tpt, you simply don't specify
> > the -1 value, ie. just remove the -1 line from the table completely.
> > IOW, instead of the patch you posted before, a simple patch just
> > removing the first line from the table should be sufficient.
> >
> > > Yes, I agree as today, "on" == "off", just thinking we should make more
> > > flexible.
> >
> > I just don't see the point since we don't really need it.
>
> Just thinking give more control to the driver, but it is ok don't have
> it
I wouldn't really mind, I just don't think it's useful before some
driver actually needs it, and all the current ones want symmetric
blinking (and also I think asymmetric would look odd).
johannes
next prev parent reply other threads:[~2011-04-24 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-24 17:15 [PATCH 1/1 RFC] mac80211: add ratio to led blinking trigger Wey-Yi Guy
2011-04-24 18:38 ` Johannes Berg
2011-04-24 18:48 ` wwguy
2011-04-24 19:29 ` Johannes Berg
2011-04-24 19:37 ` wwguy
2011-04-24 19:44 ` Johannes Berg [this message]
2011-04-24 19:49 ` wwguy
2011-04-25 7:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303674298.3603.9.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.