From: Eric Paris <eparis@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dave@linux.vnet.ibm.com, steffen.klassert@secunet.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
sds@tycho.nsa.gov
Subject: Re: [PATCH 1/3] flex_array: flex_array_prealloc takes a number of elements, not an end
Date: Tue, 26 Apr 2011 15:06:27 -0400 [thread overview]
Message-ID: <1303844791.2101.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20110426115638.379068b1.akpm@linux-foundation.org>
On Tue, 2011-04-26 at 11:56 -0700, Andrew Morton wrote:
> On Mon, 25 Apr 2011 21:45:31 -0400
> Eric Paris <eparis@redhat.com> wrote:
>
> > Change flex_array_prealloc to take the number of elements for which space
> > should be allocated instead of the last (inclusive) element. Users
> > and documentation are updated accordingly.
>
> Why?
All three of these patches came from these discussions:
http://marc.info/?t=129552800100005&r=1&w=2
http://marc.info/?t=129646395700004&r=1&w=2
http://marc.info/?t=129708178200007&r=1&w=2
1/3 was changed just because it seemed to be the way the interface was
used
2/3 was changed because the 2.6.38 kernel fails to load certain selinux
policies which worked under 2.6.37 because of this lack of functionality
3/3 was changed just because that's how maybe it should work, although
there are no known users.
I can certainly update 2/3 to better explain the rational but I can't
really do any better on 1/3 and 3/3 other than to just say what the
change is......
-Eric
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
WARNING: multiple messages have this Message-ID (diff)
From: Eric Paris <eparis@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dave@linux.vnet.ibm.com, steffen.klassert@secunet.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
sds@tycho.nsa.gov
Subject: Re: [PATCH 1/3] flex_array: flex_array_prealloc takes a number of elements, not an end
Date: Tue, 26 Apr 2011 15:06:27 -0400 [thread overview]
Message-ID: <1303844791.2101.7.camel@localhost.localdomain> (raw)
In-Reply-To: <20110426115638.379068b1.akpm@linux-foundation.org>
On Tue, 2011-04-26 at 11:56 -0700, Andrew Morton wrote:
> On Mon, 25 Apr 2011 21:45:31 -0400
> Eric Paris <eparis@redhat.com> wrote:
>
> > Change flex_array_prealloc to take the number of elements for which space
> > should be allocated instead of the last (inclusive) element. Users
> > and documentation are updated accordingly.
>
> Why?
All three of these patches came from these discussions:
http://marc.info/?t=129552800100005&r=1&w=2
http://marc.info/?t=129646395700004&r=1&w=2
http://marc.info/?t=129708178200007&r=1&w=2
1/3 was changed just because it seemed to be the way the interface was
used
2/3 was changed because the 2.6.38 kernel fails to load certain selinux
policies which worked under 2.6.37 because of this lack of functionality
3/3 was changed just because that's how maybe it should work, although
there are no known users.
I can certainly update 2/3 to better explain the rational but I can't
really do any better on 1/3 and 3/3 other than to just say what the
change is......
-Eric
next prev parent reply other threads:[~2011-04-26 19:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 1:45 [PATCH 1/3] flex_array: flex_array_prealloc takes a number of elements, not an end Eric Paris
2011-04-26 1:45 ` Eric Paris
2011-04-26 1:45 ` [PATCH 2/3] flex_arrays: allow zero length flex arrays Eric Paris
2011-04-26 1:45 ` Eric Paris
2011-04-26 18:57 ` Andrew Morton
2011-04-26 20:38 ` Dave Hansen
2011-04-26 20:44 ` Eric Paris
2011-04-26 20:44 ` Eric Paris
2011-04-26 1:45 ` [PATCH 3/3] flex_array: allow 0 length elements Eric Paris
2011-04-26 1:45 ` Eric Paris
2011-04-26 18:57 ` Andrew Morton
2011-04-26 20:46 ` Dave Hansen
2011-04-26 18:56 ` [PATCH 1/3] flex_array: flex_array_prealloc takes a number of elements, not an end Andrew Morton
2011-04-26 19:06 ` Eric Paris [this message]
2011-04-26 19:06 ` Eric Paris
2011-04-26 20:32 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303844791.2101.7.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.