From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Fabrice Deyber <fabricedeyber@agilemesh.com>,
Thomas Pedersen <thomas@cozybit.com>,
devel@lists.open80211s.org, linux-wireless@vger.kernel.org,
jlopex@gmail.com
Subject: Re: [PATCH] mac80211: Only process mesh PREPs with equal seq number if metric is better.
Date: Sat, 07 May 2011 00:38:05 +0200 [thread overview]
Message-ID: <1304721485.3595.15.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <BANLkTinoSvA2uJg7bvNiAgkDz7wsr+uJug@mail.gmail.com> (sfid-20110507_002848_039627_E0EBE5C8)
On Fri, 2011-05-06 at 15:28 -0700, Javier Cardona wrote:
> >> This fixes routing loops in PREP propagation and is in accordance with Draft
> >> 11, Section: 11C.9.8.4.
> >
> >> +++ b/net/mac80211/mesh_hwmp.c
> >> @@ -391,7 +391,6 @@ static u32 hwmp_route_info_get(struct ieee80211_sub_if_data *sdata,
> >> (mpath->flags & MESH_PATH_SN_VALID)) {
> >> if (SN_GT(mpath->sn, orig_sn) ||
> >> (mpath->sn == orig_sn &&
> >> - action == MPATH_PREQ &&
> >
> > I don't understand how removing the action comparison maps to the patch
> > description -- can you explain a bit more?
>
> If the if condition is true, this PREQ or PREP will be ignored. The
> first part of the condition eliminates old sequence numbers, where the
> metric is not checked. The second part of the if condidion (||
> (mpath->sn == ...) used to eliminate all the PREQs with equal seq
> number and worse metric. The patch modifies it to also eliminate
> PREPs.
Ah. Thanks for the explanation, guess I shouldn't be trying to read this
after midnight :-)
johannes
prev parent reply other threads:[~2011-05-06 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 22:11 [PATCH] mac80211: Only process mesh PREPs with equal seq number if metric is better Javier Cardona
2011-05-06 22:17 ` Johannes Berg
2011-05-06 22:28 ` Javier Cardona
2011-05-06 22:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304721485.3595.15.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=devel@lists.open80211s.org \
--cc=fabricedeyber@agilemesh.com \
--cc=javier@cozybit.com \
--cc=jlopex@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=thomas@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.