All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	broonie@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.
Date: Sun, 08 May 2011 15:10:21 +0100	[thread overview]
Message-ID: <1304863821.3246.4.camel@odin> (raw)
In-Reply-To: <1304426792-23540-1-git-send-email-marek.belisko@open-nandra.com>

On Tue, 2011-05-03 at 14:46 +0200, Marek Belisko wrote:
> Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
> sound from codec because code for bias setup was not compiled
> (define wasn't defined). This define was removed in commit:
> cc3202f5 but again introduced by commit: f0fba2ad1 which then
> completely break codec functionality so remove it again.
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  sound/soc/codecs/uda134x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c
> index 48ffd40..a7b8f30 100644
> --- a/sound/soc/codecs/uda134x.c
> +++ b/sound/soc/codecs/uda134x.c
> @@ -601,9 +601,7 @@ static struct snd_soc_codec_driver soc_codec_dev_uda134x = {
>  	.reg_cache_step = 1,
>  	.read = uda134x_read_reg_cache,
>  	.write = uda134x_write,
> -#ifdef POWER_OFF_ON_STANDBY
>  	.set_bias_level = uda134x_set_bias_level,
> -#endif
>  };
>  
>  static int __devinit uda134x_codec_probe(struct platform_device *pdev)

Acked-by: Liam Girdwood <lrg@ti.com>

WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: tiwai@suse.de, perex@perex.cz, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.
Date: Sun, 08 May 2011 15:10:21 +0100	[thread overview]
Message-ID: <1304863821.3246.4.camel@odin> (raw)
In-Reply-To: <1304426792-23540-1-git-send-email-marek.belisko@open-nandra.com>

On Tue, 2011-05-03 at 14:46 +0200, Marek Belisko wrote:
> Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
> sound from codec because code for bias setup was not compiled
> (define wasn't defined). This define was removed in commit:
> cc3202f5 but again introduced by commit: f0fba2ad1 which then
> completely break codec functionality so remove it again.
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  sound/soc/codecs/uda134x.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c
> index 48ffd40..a7b8f30 100644
> --- a/sound/soc/codecs/uda134x.c
> +++ b/sound/soc/codecs/uda134x.c
> @@ -601,9 +601,7 @@ static struct snd_soc_codec_driver soc_codec_dev_uda134x = {
>  	.reg_cache_step = 1,
>  	.read = uda134x_read_reg_cache,
>  	.write = uda134x_write,
> -#ifdef POWER_OFF_ON_STANDBY
>  	.set_bias_level = uda134x_set_bias_level,
> -#endif
>  };
>  
>  static int __devinit uda134x_codec_probe(struct platform_device *pdev)

Acked-by: Liam Girdwood <lrg@ti.com>


  reply	other threads:[~2011-05-08 14:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-03 12:46 [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define Marek Belisko
2011-05-08 14:10 ` Liam Girdwood [this message]
2011-05-08 14:10   ` Liam Girdwood
2011-05-08 14:34 ` Mark Brown
2011-05-08 14:34   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304863821.3246.4.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.belisko@open-nandra.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.