Re: linux-next: build failure after merge of the voltage tree

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Tue, 2011-05-10 at 12:30 -0500, Jorge Eduardo Candelaria wrote:
> On May 10, 2011, at 3:38 AM, Liam Girdwood wrote:
> 
> > On Tue, 2011-05-10 at 12:44 +1000, Stephen Rothwell wrote:
> >> Hi Liam,
> >> 
> >> After merging the voltage tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >> 
> >> ERROR: "tps65910_gpio_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "tps65910_irq_init" [drivers/mfd/tps65910.ko] undefined!
> >> ERROR: "irq_modify_status" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "irq_set_chip_and_handler_name" [drivers/mfd/tps65910-irq.ko] undefined!
> >> ERROR: "handle_edge_irq" [drivers/mfd/tps65910-irq.ko] undefined!
> >> 
> >> I have used the voltage tree from next-20110509 for today.
> > 
> > Jorge, could you send a fix for this today.
> > 
> > Thanks
> > 
> > Liam
> > 
> 
> The following patch should solve this:
> 
> From: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> MFD: Fix TPS65910 build
> 
> Support for tps65910 as a module is not available. The driver can
> only be compiled as built-in. OTOH, the regulator driver can still
> be built as module without breaking the compilation.
> 
> Signed-off-by: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
> ---
>  drivers/mfd/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 65930a7..c78865e 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -672,8 +672,8 @@ config MFD_OMAP_USB_HOST
>  	  OMAP USB Host drivers.
>  
>  config MFD_TPS65910
> -	tristate "TPS65910 Power Management chip"
> -	depends on I2C &&  GPIOLIB
> +	bool "TPS65910 Power Management chip"
> +	depends on I2C && GPIOLIB
>  	select MFD_CORE
>  	help
>  	  if you say yes here you get support for the TPS65910 series of


Applied.

Thanks

Liam