From: Peter Zijlstra <peterz@infradead.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Mike Galbraith <efault@gmx.de>,
Yong Zhang <yong.zhang0@gmail.com>,
Andreas Herrmann <andreas.herrmann3@amd.com>
Subject: Re: [PATCH] sched: fix constructing the span cpu mask of sched domain
Date: Wed, 11 May 2011 15:54:15 +0200 [thread overview]
Message-ID: <1305122055.2914.220.camel@laptop> (raw)
In-Reply-To: <BANLkTin5iNMt2autv3TJpCvTQUoKsSzhTA@mail.gmail.com>
On Wed, 2011-05-11 at 21:26 +0800, Hillf Danton wrote:
> Your work for rewriting NUMA support, published at
> http://marc.info/?l=linux-kernel&m=130218515520540
> is patched by changing how level is computed and by changing how it is
> used to build the mask.
>
> When computing, some valid levels are lost in your work.
>
> When building mask, nodes are selected only if they have same distance,
> thus nodes of less distance are also masked out since the computation of
> level now is tough.
>
> Without MUNA hardware, I did not test the patch:(
I do have a (tiny) NUMA box (2 nodes) but that actually booted with the
old code too, Andreas Hermann from AMD (CC'ed) is usually willing to
test such patches on somewhat larger systems. Please send a full patch
against tip/master for him to apply.
next prev parent reply other threads:[~2011-05-11 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 12:53 [PATCH] sched: fix constructing the span cpu mask of sched domain Hillf Danton
2011-05-06 7:12 ` Ingo Molnar
2011-05-06 7:40 ` [tip:sched/core] sched: Shorten the construction of " tip-bot for Hillf Danton
2011-05-10 8:32 ` [PATCH] sched: fix constructing " Peter Zijlstra
2011-05-10 12:29 ` Hillf Danton
2011-05-11 13:26 ` Hillf Danton
2011-05-11 13:54 ` Peter Zijlstra [this message]
2011-05-11 14:10 ` Hillf Danton
2011-05-11 14:15 ` Ingo Molnar
2011-05-11 14:23 ` Hillf Danton
2011-05-13 13:06 ` Hillf Danton
2011-05-15 5:50 ` Hillf Danton
2011-05-17 9:23 ` Andreas Herrmann
2011-05-17 14:36 ` Hillf Danton
2011-05-18 2:45 ` Yong Zhang
2011-05-18 15:12 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305122055.2914.220.camel@laptop \
--to=peterz@infradead.org \
--cc=andreas.herrmann3@amd.com \
--cc=dhillf@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.