From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: Vimal Singh <vimal.newwork@gmail.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
stable@kernel.org
Subject: Re: [PATCH RESEND] omap : nand : fix subpage ecc issue with prefetch
Date: Thu, 12 May 2011 15:56:00 +0300 [thread overview]
Message-ID: <1305204960.14423.0.camel@localhost> (raw)
In-Reply-To: <1305128847-12987-1-git-send-email-kishore.kadiyala@ti.com>
On Wed, 2011-05-11 at 21:17 +0530, Kishore Kadiyala wrote:
> When reading/writing a subpage (When HW ECC is not available/enabled)
> for number of bytes not aligned to 4, the mis-aligned bytes are handled
> first (by cpu copy method) before enabling the Prefetch engine to/from
> 'p'(start of buffer 'buf'). Then it reads/writes rest of the bytes with
> the help of Prefetch engine, if available, or again using cpu copy method.
> Currently, reading/writing of rest of bytes, is not done correctly since
> its trying to read/write again to/from begining of buffer 'buf',
> overwriting the mis-aligned bytes.
>
> Read & write using prefetch engine got broken in commit '2c01946c'.
> We never hit a scenario of not getting 'gpmc_prefetch_enable' call
> success. So, problem did not get caught up.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> Signed-off-by: Vimal Singh <vimal.newwork@gmail.com>
> Reported-by: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
> Cc: stable@kernel.org [2.6.35+]
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kishore Kadiyala <kishore.kadiyala@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
stable@kernel.org, Vimal Singh <vimal.newwork@gmail.com>
Subject: Re: [PATCH RESEND] omap : nand : fix subpage ecc issue with prefetch
Date: Thu, 12 May 2011 15:56:00 +0300 [thread overview]
Message-ID: <1305204960.14423.0.camel@localhost> (raw)
In-Reply-To: <1305128847-12987-1-git-send-email-kishore.kadiyala@ti.com>
On Wed, 2011-05-11 at 21:17 +0530, Kishore Kadiyala wrote:
> When reading/writing a subpage (When HW ECC is not available/enabled)
> for number of bytes not aligned to 4, the mis-aligned bytes are handled
> first (by cpu copy method) before enabling the Prefetch engine to/from
> 'p'(start of buffer 'buf'). Then it reads/writes rest of the bytes with
> the help of Prefetch engine, if available, or again using cpu copy method.
> Currently, reading/writing of rest of bytes, is not done correctly since
> its trying to read/write again to/from begining of buffer 'buf',
> overwriting the mis-aligned bytes.
>
> Read & write using prefetch engine got broken in commit '2c01946c'.
> We never hit a scenario of not getting 'gpmc_prefetch_enable' call
> success. So, problem did not get caught up.
>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> Signed-off-by: Vimal Singh <vimal.newwork@gmail.com>
> Reported-by: Bryan DE FARIA <bdefaria@adeneo-embedded.com>
> Cc: stable@kernel.org [2.6.35+]
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-12 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 15:47 [PATCH RESEND] omap : nand : fix subpage ecc issue with prefetch Kishore Kadiyala
2011-05-11 15:47 ` Kishore Kadiyala
2011-05-12 12:56 ` Artem Bityutskiy [this message]
2011-05-12 12:56 ` Artem Bityutskiy
-- strict thread matches above, loose matches on Subject: below --
2011-05-11 14:24 Kishore Kadiyala
2011-05-11 14:24 ` Kishore Kadiyala
2011-05-11 14:54 ` Greg KH
2011-05-11 15:37 ` Kishore Kadiyala
2011-05-09 14:21 Kishore Kadiyala
2011-05-09 14:21 ` Kishore Kadiyala
2011-05-11 14:15 ` Kishore Kadiyala
2011-05-11 14:15 ` Kishore Kadiyala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305204960.14423.0.camel@localhost \
--to=dedekind1@gmail.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=stable@kernel.org \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.