RE: [PATCH] rtc-twl: Switch to using threaded irq

[John Stultz <john.stultz@linaro.org>]

On Thu, 2011-05-05 at 07:51 +0000, ilkka.koskinen@nokia.com wrote:
> Hi,
> 
> Tony and John: What would be the appropriate path for this patch?

I'd probably push it through omap maintainer path, as its hardware
specific and can be better tested there.

thanks
-john


> On Apr 13, 2011 Krishnamoorthy, Balaji T  wrote:
> >On Wed, Mar 16, 2011 at 9:37 PM, Ilkka Koskinen
> <ilkka.koskinen@nokia.com> wrote:
> >>
> >> The driver is accessing to i2c bus in interrupt handler.
> >> Therefore, it should use threaded irq.
> 
> >Acked-by: Balaji T K <balajitk@ti.com>
> 
> >>
> >> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> >> ---
> >>  drivers/rtc/rtc-twl.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c
> >> index ed1b868..2715b96 100644
> >> --- a/drivers/rtc/rtc-twl.c
> >> +++ b/drivers/rtc/rtc-twl.c
> >> @@ -475,7 +475,7 @@ static int __devinit twl_rtc_probe(struct platform_device *pdev)
> >>        if (ret < 0)
> >>                goto out1;
> >>
> >> -       ret = request_irq(irq, twl_rtc_interrupt,
> >> +       ret = request_threaded_irq(irq, NULL, twl_rtc_interrupt,
> >>                                IRQF_TRIGGER_RISING,
> >>                                dev_name(&rtc->dev), rtc);
> >>        if (ret < 0) {
> >> --
> >> 1.7.0.4
> >>