All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Sebastian Reichel <sre@debian.org>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
	a.zummo@towertech.it, rtc-linux@googlegroups.com,
	balajitk@ti.com, Ilkka Koskinen <ilkkakos@kolumbus.fi>
Subject: Re: [PATCH] rtc-twl: Switch to using threaded irq
Date: Wed, 10 Aug 2011 15:44:11 -0700	[thread overview]
Message-ID: <1313016251.15198.87.camel@work-vm> (raw)
In-Reply-To: <20110627164506.GA10827@earth.universe>

On Mon, 2011-06-27 at 18:45 +0200, Sebastian Reichel wrote:
> On Tue, May 31, 2011 at 10:51:39AM +0200, Sebastian Reichel wrote:
> > > The driver is accessing to i2c bus in interrupt handler.
> > > Therefore, it should use threaded irq.
> > I think the patch should also remove the local_irq_enable() call in
> > twl_rtc_interrupt, since it's no longer needed with threaded irq. At
> > least on the Pandaboard the RTC is still working with the appended
> > patch.
> 
> ping.
> 
> Currently the kernel prints a stacktrace for each rtc-twl interrupt,
> because its interrupt handler enables interrupts.

I've queued both changes. Thanks for the reminder.

thanks
-john



      reply	other threads:[~2011-08-10 22:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 16:07 [PATCH] rtc-twl: Switch to using threaded irq Ilkka Koskinen
2011-04-13  7:41 ` Krishnamoorthy, Balaji T
2011-05-05  7:51   ` ilkka.koskinen
2011-05-12 23:24     ` John Stultz
2011-05-18 19:20       ` Ilkka Koskinen
2011-05-31  8:51         ` Sebastian Reichel
2011-06-27 16:45           ` Sebastian Reichel
2011-08-10 22:44             ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313016251.15198.87.camel@work-vm \
    --to=john.stultz@linaro.org \
    --cc=a.zummo@towertech.it \
    --cc=balajitk@ti.com \
    --cc=ilkkakos@kolumbus.fi \
    --cc=linux-omap@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=sre@debian.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.