All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH 1/9] iwlegacy: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning
Date: Thu, 12 May 2011 16:50:04 -0700	[thread overview]
Message-ID: <1305244212-19183-2-git-send-email-sboyd@codeaurora.org> (raw)
In-Reply-To: <1305244212-19183-1-git-send-email-sboyd@codeaurora.org>

Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
warning:

In file included from arch/x86/include/asm/uaccess.h:573,
                 from include/net/checksum.h:25,
                 from include/linux/skbuff.h:28,
                 from drivers/net/wireless/iwlegacy/iwl-4965-rs.c:28:
In function 'copy_from_user',
    inlined from 'iwl4965_rs_sta_dbgfs_scale_table_write' at
    drivers/net/wireless/iwlegacy/iwl-4965-rs.c:2616:
arch/x86/include/asm/uaccess_64.h:65:
warning: call to 'copy_from_user_overflow' declared with
attribute warning: copy_from_user() buffer size is not provably
correct

presumably due to buf_size being signed causing GCC to fail to
see that buf_size can't become negative.

Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/net/wireless/iwlegacy/iwl-4965-rs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
index 31ac672..cc4751c 100644
--- a/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
+++ b/drivers/net/wireless/iwlegacy/iwl-4965-rs.c
@@ -2604,7 +2604,7 @@ static ssize_t iwl4965_rs_sta_dbgfs_scale_table_write(struct file *file,
 	struct iwl_lq_sta *lq_sta = file->private_data;
 	struct iwl_priv *priv;
 	char buf[64];
-	int buf_size;
+	size_t buf_size;
 	u32 parsed_rate;
 	struct iwl_station_priv *sta_priv =
 		container_of(lq_sta, struct iwl_station_priv, lq_sta);
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


  reply	other threads:[~2011-05-12 23:50 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 23:50 [PATCH 0/9] strict user copy checks on x86_64 Stephen Boyd
2011-05-12 23:50 ` Stephen Boyd [this message]
2011-05-13  0:01   ` [PATCH 1/9] iwlegacy: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning wwguy
2011-05-13  9:08   ` Stanislaw Gruszka
2011-05-12 23:50 ` [PATCH 2/9] iwlwifi: " Stephen Boyd
2011-05-13  0:02   ` wwguy
2011-05-12 23:50 ` [PATCH 3/9] [SCSI] lpfc: " Stephen Boyd
2011-05-24 13:32   ` James Smart
2011-05-12 23:50 ` [PATCH 4/9] debugfs: " Stephen Boyd
2011-05-13 23:14   ` Greg KH
2011-05-12 23:50 ` [PATCH 5/9] kprobes: " Stephen Boyd
2011-05-13  0:29   ` Masami Hiramatsu
2011-05-12 23:50 ` [PATCH 6/9] Bluetooth: " Stephen Boyd
2011-05-13 21:06   ` Gustavo F. Padovan
2011-05-13 21:06     ` Gustavo F. Padovan
2011-05-12 23:50 ` [PATCH 7/9] ASoC: " Stephen Boyd
2011-05-16 16:26   ` Liam Girdwood
2011-05-16 16:26     ` Liam Girdwood
2011-05-16 20:22   ` Mark Brown
2011-05-16 20:22     ` Mark Brown
2011-05-12 23:50 ` [PATCH 8/9] x86: Implement strict user copy checks for x86_64 Stephen Boyd
2011-05-13 10:15   ` Ingo Molnar
2011-05-12 23:50 ` [PATCH 9/9] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2011-05-13  0:55   ` Chris Metcalf
2011-05-13  0:55     ` Chris Metcalf
2011-05-13  7:31   ` Ingo Molnar
2011-05-13 16:55   ` Arnd Bergmann
2011-05-24 21:29 ` [PATCH 0/9] strict user copy checks on x86_64 Stephen Boyd
2011-05-24 23:33   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305244212-19183-2-git-send-email-sboyd@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.