From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Helge Deller <deller@gmx.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Chris Metcalf <cmetcalf@tilera.com>
Subject: Re: [PATCH 9/9] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS
Date: Fri, 13 May 2011 18:55:09 +0200 [thread overview]
Message-ID: <201105131855.10195.arnd@arndb.de> (raw)
In-Reply-To: <1305244212-19183-10-git-send-email-sboyd@codeaurora.org>
On Friday 13 May 2011, Stephen Boyd wrote:
> The help text for this config is duplicated across the x86,
> parisc, and s390 Kconfig.debug files. Arnd Bergman noted that the
> help text was slightly misleading and should be fixed to state
> that enabling this option isn't a problem when using pre 4.4 gcc.
>
> To simplify the rewording, consolidate the text into
> lib/Kconfig.debug and modify it there to be more explicit about
> when you should say N to this config.
>
> Also, make the text a bit more generic by stating that this
> option enables compile time checks so we can cover architectures
> which emit warnings vs. ones which emit errors. The details of
> how an architecture decided to implement the checks isn't as
> important as the concept of compile time checking of
> copy_from_user() calls.
>
> While we're doing this, remove all the copy_from_user_overflow()
> code that's duplicated many times and place it into lib/ so that
> any architecture supporting this option can get the function for
> free.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: x86@kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-s390@vger.kernel.org
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks for following up on this
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2011-05-13 16:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 23:50 [PATCH 0/9] strict user copy checks on x86_64 Stephen Boyd
2011-05-12 23:50 ` [PATCH 1/9] iwlegacy: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning Stephen Boyd
2011-05-13 0:01 ` wwguy
2011-05-13 9:08 ` Stanislaw Gruszka
2011-05-12 23:50 ` [PATCH 2/9] iwlwifi: " Stephen Boyd
2011-05-13 0:02 ` wwguy
2011-05-12 23:50 ` [PATCH 3/9] [SCSI] lpfc: " Stephen Boyd
2011-05-24 13:32 ` James Smart
2011-05-12 23:50 ` [PATCH 4/9] debugfs: " Stephen Boyd
2011-05-13 23:14 ` Greg KH
2011-05-12 23:50 ` [PATCH 5/9] kprobes: " Stephen Boyd
2011-05-13 0:29 ` Masami Hiramatsu
2011-05-12 23:50 ` [PATCH 6/9] Bluetooth: " Stephen Boyd
2011-05-13 21:06 ` Gustavo F. Padovan
2011-05-13 21:06 ` Gustavo F. Padovan
2011-05-12 23:50 ` [PATCH 7/9] ASoC: " Stephen Boyd
2011-05-16 16:26 ` Liam Girdwood
2011-05-16 16:26 ` Liam Girdwood
2011-05-16 20:22 ` Mark Brown
2011-05-16 20:22 ` Mark Brown
2011-05-12 23:50 ` [PATCH 8/9] x86: Implement strict user copy checks for x86_64 Stephen Boyd
2011-05-13 10:15 ` Ingo Molnar
2011-05-12 23:50 ` [PATCH 9/9] Consolidate CONFIG_DEBUG_STRICT_USER_COPY_CHECKS Stephen Boyd
2011-05-13 0:55 ` Chris Metcalf
2011-05-13 0:55 ` Chris Metcalf
2011-05-13 7:31 ` Ingo Molnar
2011-05-13 16:55 ` Arnd Bergmann [this message]
2011-05-24 21:29 ` [PATCH 0/9] strict user copy checks on x86_64 Stephen Boyd
2011-05-24 23:33 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105131855.10195.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=cmetcalf@tilera.com \
--cc=deller@gmx.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sfr@canb.auug.org.au \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.