From: utx@penguin.cz (Stanislav Brabec)
To: linux-arm-kernel@lists.infradead.org
Subject: Disable CF during suspend
Date: Sat, 21 May 2011 16:27:58 +0200 [thread overview]
Message-ID: <1305988078.5824.14.camel@utx.lan> (raw)
In-Reply-To: <20110521094326.GB26323@elf.ucw.cz>
Pavel Machek wrote:
> Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
> fast. Thanks to Stanislav Brabec.
If you can verify that your card turns off on suspend, then you have my:
Acked-by: Stanislav Brabec <utx@penguin.cz>
But I would line to see more aggressive power control, something like
spitz_card_pwr_ctrl() in old kernels - if there is no CF and no
(external) CF card inserted, then SPITZ_SCP_CF_POWER card be turned off.
If they are memory cards, they can be turned off even while idle.
--
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx, ICQ 116020046, xmpp:utx at jabber.cz
WARNING: multiple messages have this Message-ID (diff)
From: Stanislav Brabec <utx@penguin.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
arminlitzel@web.de, Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com, eric.y.miao@gmail.com,
zaurus-devel@www.linuxtogo.org,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: Disable CF during suspend
Date: Sat, 21 May 2011 16:27:58 +0200 [thread overview]
Message-ID: <1305988078.5824.14.camel@utx.lan> (raw)
In-Reply-To: <20110521094326.GB26323@elf.ucw.cz>
Pavel Machek wrote:
> Disable SPITZ_SCP_CF_POWER during suspend. Otherwise it eats battery,
> fast. Thanks to Stanislav Brabec.
If you can verify that your card turns off on suspend, then you have my:
Acked-by: Stanislav Brabec <utx@penguin.cz>
But I would line to see more aggressive power control, something like
spitz_card_pwr_ctrl() in old kernels - if there is no CF and no
(external) CF card inserted, then SPITZ_SCP_CF_POWER card be turned off.
If they are memory cards, they can be turned off even while idle.
--
________________________________________________________________________
Stanislav Brabec
http://www.penguin.cz/~utx, ICQ 116020046, xmpp:utx@jabber.cz
next prev parent reply other threads:[~2011-05-21 14:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 9:43 Disable CF during suspend Pavel Machek
2011-05-21 9:43 ` Pavel Machek
2011-05-21 14:27 ` Stanislav Brabec [this message]
2011-05-21 14:27 ` Stanislav Brabec
2011-05-21 14:35 ` Pavel Machek
2011-05-21 14:35 ` Pavel Machek
2011-06-06 13:05 ` Cyril Hrubis
2011-06-06 13:05 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305988078.5824.14.camel@utx.lan \
--to=utx@penguin.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.