Re: net: enable dynamic lro disabling for vlans

[Ben Hutchings <bhutchings@solarflare.com>]

On Tue, 2011-05-24 at 13:15 -0400, Neil Horman wrote:
> Hey there-
> 	Noted recently that, while physical devices have lro disabled when
> attached to a bridge, vlan devices do not.

Good point.

> This is because the vlan netdev has
> no get/set flags method in its ethtool_ops struct. This series adds those
> methods as passthrough calls to the underlying physical devices, so that whe
> dev_disable_lro is called on a vlan device, the physical device underneath has
> lro properly disabled.

But I don't think this is correct.

The get_flags() result should be masked with vlan_features.  And
set_flags() shouldn't be allowed; the VLAN device should normally follow
the parent device and not the other way round.  I think
dev_disable_lro() needs to handle VLAN devices explicitly, instead.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.