All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, bhutchings@solarflare.com
Subject: Re: [PATCH 1/2] net: move is_vlan_dev into public header file (v2)
Date: Tue, 24 May 2011 11:36:35 -0700	[thread overview]
Message-ID: <1306262195.2298.46.camel@Joe-Laptop> (raw)
In-Reply-To: <1306261869-7276-2-git-send-email-nhorman@tuxdriver.com>

On Tue, 2011-05-24 at 14:31 -0400, Neil Horman wrote:
> Migrate is_vlan_dev() to if_vlan.h so that core networkig can use it
[]
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
[]
> @@ -110,6 +110,11 @@ static inline void vlan_group_set_device(struct vlan_group *vg,
>  	array[vlan_id % VLAN_GROUP_ARRAY_PART_LEN] = dev;
>  }
>  
> +static inline int is_vlan_dev(struct net_device *dev)
> +{
> +        return dev->priv_flags & IFF_802_1Q_VLAN;
> +}

perhaps:

static bool is_vlan_dev(const struct net_device *dev)
{
	return !!(dev->priv_flags & IFF_802_1Q_VLAN);
}



  reply	other threads:[~2011-05-24 18:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 17:15 net: enable dynamic lro disabling for vlans Neil Horman
2011-05-24 17:15 ` [PATCH 1/2] net: add dev_ethtool_set_flags helper Neil Horman
2011-05-24 17:15 ` [PATCH 2/2] net: add passthrough ethtool commands for get/set flags to vlan dev Neil Horman
2011-05-24 17:22 ` net: enable dynamic lro disabling for vlans Ben Hutchings
2011-05-24 17:54   ` Neil Horman
2011-05-24 18:31 ` net: enable dynamic lro disabling for vlans (v2) Neil Horman
2011-05-24 18:31   ` [PATCH 1/2] net: move is_vlan_dev into public header file (v2) Neil Horman
2011-05-24 18:36     ` Joe Perches [this message]
2011-05-24 19:03       ` Neil Horman
2011-05-25 21:56     ` David Miller
2011-05-24 18:31   ` [PATCH 2/2] net: make dev_disable_lro use physical device if passed a vlan dev (v2) Neil Horman
2011-05-25 21:56     ` David Miller
2011-05-28  3:11     ` Ben Hutchings
2011-05-31  0:06       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306262195.2298.46.camel@Joe-Laptop \
    --to=joe@perches.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.