All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
	linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	netdev@vger.kernel.org
Subject: Re: bridge/netfilter: regression in 2.6.39.1
Date: Fri, 03 Jun 2011 23:31:10 +0100	[thread overview]
Message-ID: <1307140270.22348.114.camel@localhost> (raw)
In-Reply-To: <1307129642.2600.2.camel@edumazet-laptop>

On Fri, 2011-06-03 at 21:34 +0200, Eric Dumazet wrote:
> Le vendredi 03 juin 2011 à 21:21 +0200, Alexander Holler a écrit :
> > Hello,
> > 
> > I'm getting a oops in the bridge code in br_change_mtu() with 2.6.39.1. 
> > The patch below seems to fix that.
> > 
> > I'm not sure about the usage of dst_cow_metrics_generic() in 
> > fake_dst_ops, but after having a quick look at it seems to be ok to use 
> > that here.
> > 
> > Regards,
> > 
> > Alexander
> > 
> > -----
> >  From 3c1d5951af73389798afeea672ec224e195b8e8d Mon Sep 17 00:00:00 2001
> > From: Alexander Holler <holler@ahsoftware.de>
> > Date: Fri, 3 Jun 2011 20:43:06 +0200
> > Subject: [PATCH] bridge: add dst_cow_metrics_generic to fake_dst_ops
> > 
> > Commit 42923465fb8d025a2b5153f2e7ab1e6e1058bf00 does here what it
> > should prevent, it introduces NULL a dereference.
> > 
> 
> I cant find this commit in known trees. Could you give the real commit
> id and its title ?
[...]

It's your commit 33eb9873a283a2076f2b5628813d5365ca420ea9, applied to
2.6.39.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


WARNING: multiple messages have this Message-ID (diff)
From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Alexander Holler <holler@ahsoftware.de>,
	linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org
Subject: Re: bridge/netfilter: regression in 2.6.39.1
Date: Fri, 03 Jun 2011 23:31:10 +0100	[thread overview]
Message-ID: <1307140270.22348.114.camel@localhost> (raw)
In-Reply-To: <1307129642.2600.2.camel@edumazet-laptop>

On Fri, 2011-06-03 at 21:34 +0200, Eric Dumazet wrote:
> Le vendredi 03 juin 2011 à 21:21 +0200, Alexander Holler a écrit :
> > Hello,
> > 
> > I'm getting a oops in the bridge code in br_change_mtu() with 2.6.39.1. 
> > The patch below seems to fix that.
> > 
> > I'm not sure about the usage of dst_cow_metrics_generic() in 
> > fake_dst_ops, but after having a quick look at it seems to be ok to use 
> > that here.
> > 
> > Regards,
> > 
> > Alexander
> > 
> > -----
> >  From 3c1d5951af73389798afeea672ec224e195b8e8d Mon Sep 17 00:00:00 2001
> > From: Alexander Holler <holler@ahsoftware.de>
> > Date: Fri, 3 Jun 2011 20:43:06 +0200
> > Subject: [PATCH] bridge: add dst_cow_metrics_generic to fake_dst_ops
> > 
> > Commit 42923465fb8d025a2b5153f2e7ab1e6e1058bf00 does here what it
> > should prevent, it introduces NULL a dereference.
> > 
> 
> I cant find this commit in known trees. Could you give the real commit
> id and its title ?
[...]

It's your commit 33eb9873a283a2076f2b5628813d5365ca420ea9, applied to
2.6.39.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  parent reply	other threads:[~2011-06-03 22:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-03 19:21 bridge/netfilter: regression in 2.6.39.1 Alexander Holler
2011-06-03 19:21 ` Alexander Holler
2011-06-03 19:34 ` Eric Dumazet
2011-06-03 19:34   ` Eric Dumazet
2011-06-03 19:42   ` Alexander Holler
2011-06-03 19:42     ` Alexander Holler
2011-06-03 19:51   ` Alexander Holler
2011-06-03 19:51     ` Alexander Holler
2011-06-03 19:55     ` Eric Dumazet
2011-06-03 19:55       ` Eric Dumazet
2011-06-04 12:04       ` Alexander Holler
2011-06-04 12:04         ` Alexander Holler
2011-06-06  6:57         ` Alexander Holler
2011-06-06  6:57           ` Alexander Holler
2011-06-03 22:31   ` Ben Hutchings [this message]
2011-06-03 22:31     ` Ben Hutchings
2011-06-06 11:15 ` Neil Horman
2011-06-06 11:15   ` Neil Horman
2011-06-06 11:48   ` Alexander Holler
2011-06-06 11:48     ` Alexander Holler
2011-06-06 12:12     ` Eric Dumazet
2011-06-06 12:12       ` Eric Dumazet
2011-06-06 12:49       ` Alexander Holler
2011-06-06 12:49         ` Alexander Holler
2011-06-06 13:13         ` Neil Horman
2011-06-06 13:13           ` Neil Horman
2011-06-06 13:18           ` Eric Dumazet
2011-06-06 13:18             ` Eric Dumazet
2011-06-06 13:16         ` Eric Dumazet
2011-06-06 13:16           ` Eric Dumazet
2011-06-06 13:29           ` Alexander Holler
2011-06-06 13:29             ` Alexander Holler
2011-06-06 14:26             ` Eric Dumazet
2011-06-06 14:26               ` Eric Dumazet
2011-06-06 15:32               ` Neil Horman
2011-06-06 15:32                 ` Neil Horman
2011-06-06 16:11                 ` Eric Dumazet
2011-06-06 16:11                   ` Eric Dumazet
2011-06-06 17:07                   ` Neil Horman
2011-06-06 17:07                     ` Neil Horman
2011-06-07  7:52               ` David Miller
2011-06-06 13:09       ` Eric Dumazet
2011-06-06 13:09         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307140270.22348.114.camel@localhost \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=holler@ahsoftware.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.