From: Pekka Enberg <penberg@kernel.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, Cyrill Gorcunov <gorcunov@gmail.com>,
Ingo Molnar <mingo@elte.hu>, John Floren <john@jfloren.net>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: [PATCH v2] kvm tools, vesa: Use guest-mapped memory for framebuffer
Date: Mon, 06 Jun 2011 17:05:00 +0300 [thread overview]
Message-ID: <1307369100.27309.9.camel@jaguar> (raw)
In-Reply-To: <5D948741-FBA0-40AE-8C74-9653BB33025D@suse.de>
On Mon, 2011-06-06 at 15:59 +0200, Alexander Graf wrote:
> Please keep in mind that this is pretty fragile. It will probably work out for you now, but memslots are
>
> 1) limited
I assume KVM_SET_USER_MEMORY_REGION doesn't fail silenty here?
> 2) don't deal with overlap
>
> So please add at least a comment here, warning people that this is a
> very simple implementation that could break in subtile ways when
> implementing other hardware that could map its own memory regions
> somewhere else (PCI BARs), but wants them backed by RAM.
Sure - I'll add a comment saying the function doesn't handle overlapping
memory regions.
next prev parent reply other threads:[~2011-06-06 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 13:56 [PATCH v2] kvm tools, vesa: Use guest-mapped memory for framebuffer Pekka Enberg
2011-06-06 13:59 ` Alexander Graf
2011-06-06 14:05 ` Pekka Enberg [this message]
2011-06-06 14:06 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307369100.27309.9.camel@jaguar \
--to=penberg@kernel.org \
--cc=agraf@suse.de \
--cc=gorcunov@gmail.com \
--cc=john@jfloren.net \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.