From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
efault@gmx.de, Arne Jansen <lists@die-jansens.de>
Subject: Re: [PATCH 2/3] printk, lockdep: Remove lockdep_off() usage
Date: Fri, 10 Jun 2011 15:23:55 +0200 [thread overview]
Message-ID: <1307712235.3941.154.camel@twins> (raw)
In-Reply-To: <20110609131307.539373927@chello.nl>
On Thu, 2011-06-09 at 15:06 +0200, Peter Zijlstra wrote:
> Remove the lockdep_off() usage from printk(). Also add a
> debug_locks_off() call to zap_locks() since that'll mess up the lock
> state in a royal way anyway. Further switch to local_irq_ ops so that
> the irq state is properly tracked (raw_local_irq_* isn't tracked by
> lockdep, causing confusion). Also drop superfluous preempt_disable(),
> disabling IRQs already avoids scheduling.
>
OK, so while trying to decipher the irq status of printk() I found
commit 1efc5da3 which explains why we've got lockdep_off() in there,
there still is a recursion problem with trace_hardirqs_*.
/me goes poke at that..
next prev parent reply other threads:[~2011-06-10 13:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 13:06 [PATCH 0/3] printk: Remove lockdep_off() and wakeups Peter Zijlstra
2011-06-09 13:06 ` [PATCH 1/3] printk: Release console_sem after logbuf_lock Peter Zijlstra
2011-06-09 20:06 ` Andrew Morton
2011-06-09 20:27 ` Ingo Molnar
2011-06-09 20:54 ` Peter Zijlstra
2011-06-09 21:07 ` Andrew Morton
2011-06-09 23:57 ` Hugh Dickins
2011-06-10 0:08 ` Andrew Morton
2011-06-10 9:33 ` Ingo Molnar
2011-06-10 9:40 ` Peter Zijlstra
2011-06-10 9:42 ` Peter Zijlstra
2011-06-10 11:28 ` Peter Zijlstra
2011-06-10 12:30 ` Peter Zijlstra
2011-06-10 12:30 ` Peter Zijlstra
2011-06-10 12:34 ` Ingo Molnar
2011-06-10 12:34 ` Ingo Molnar
2011-06-10 12:41 ` Peter Zijlstra
2011-06-10 12:41 ` Peter Zijlstra
2011-06-10 12:42 ` Peter Zijlstra
2011-06-10 12:42 ` Peter Zijlstra
2011-06-23 19:03 ` Pavel Machek
2011-06-10 9:30 ` Ingo Molnar
2011-06-10 10:15 ` Peter Zijlstra
2011-06-09 13:06 ` [PATCH 2/3] printk, lockdep: Remove lockdep_off() usage Peter Zijlstra
2011-06-10 13:23 ` Peter Zijlstra [this message]
2011-06-09 13:06 ` [PATCH 3/3] printk: Avoid all wakeups from printk Peter Zijlstra
2011-06-09 13:32 ` Ingo Molnar
2011-06-09 13:40 ` Peter Zijlstra
2011-06-09 13:55 ` Ingo Molnar
2011-06-09 14:06 ` Peter Zijlstra
2011-06-09 14:19 ` Ingo Molnar
2011-06-09 14:23 ` Peter Zijlstra
2011-06-09 15:47 ` Linus Torvalds
2011-06-09 15:51 ` Ingo Molnar
2011-06-09 16:25 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307712235.3941.154.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@die-jansens.de \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.