From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, efault@gmx.de,
Arne Jansen <lists@die-jansens.de>
Subject: Re: [PATCH 1/3] printk: Release console_sem after logbuf_lock
Date: Fri, 10 Jun 2011 11:30:49 +0200 [thread overview]
Message-ID: <20110610093049.GG27280@elte.hu> (raw)
In-Reply-To: <1307652883.2497.1028.camel@laptop>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > => only a 'there be dragons' mental marker
>
> Right, my reply was that I couldn't convince myself unlock order
> could make a difference, but clearly I can easily have missed
> something subtle.
>
> > and i have to say that when i found a boot lockup during testing
> > i was not surprised very much :)
>
> But you found a lockup on the second patch, not this one.
Yeah, it's not like my mental markers are overly precise! ;-)
> Also, this patch is important for #3, where we want to take
> logbuf_lock under the semaphore internal lock, that too would
> preclude us doing that up() in the old location.
Yeah. I'm not against it or anything (hey i suggested the whole
thing), but i'll be testing this through carefully.
Thanks,
Ingo
next prev parent reply other threads:[~2011-06-10 9:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 13:06 [PATCH 0/3] printk: Remove lockdep_off() and wakeups Peter Zijlstra
2011-06-09 13:06 ` [PATCH 1/3] printk: Release console_sem after logbuf_lock Peter Zijlstra
2011-06-09 20:06 ` Andrew Morton
2011-06-09 20:27 ` Ingo Molnar
2011-06-09 20:54 ` Peter Zijlstra
2011-06-09 21:07 ` Andrew Morton
2011-06-09 23:57 ` Hugh Dickins
2011-06-10 0:08 ` Andrew Morton
2011-06-10 9:33 ` Ingo Molnar
2011-06-10 9:40 ` Peter Zijlstra
2011-06-10 9:42 ` Peter Zijlstra
2011-06-10 11:28 ` Peter Zijlstra
2011-06-10 12:30 ` Peter Zijlstra
2011-06-10 12:30 ` Peter Zijlstra
2011-06-10 12:34 ` Ingo Molnar
2011-06-10 12:34 ` Ingo Molnar
2011-06-10 12:41 ` Peter Zijlstra
2011-06-10 12:41 ` Peter Zijlstra
2011-06-10 12:42 ` Peter Zijlstra
2011-06-10 12:42 ` Peter Zijlstra
2011-06-23 19:03 ` Pavel Machek
2011-06-10 9:30 ` Ingo Molnar [this message]
2011-06-10 10:15 ` Peter Zijlstra
2011-06-09 13:06 ` [PATCH 2/3] printk, lockdep: Remove lockdep_off() usage Peter Zijlstra
2011-06-10 13:23 ` Peter Zijlstra
2011-06-09 13:06 ` [PATCH 3/3] printk: Avoid all wakeups from printk Peter Zijlstra
2011-06-09 13:32 ` Ingo Molnar
2011-06-09 13:40 ` Peter Zijlstra
2011-06-09 13:55 ` Ingo Molnar
2011-06-09 14:06 ` Peter Zijlstra
2011-06-09 14:19 ` Ingo Molnar
2011-06-09 14:23 ` Peter Zijlstra
2011-06-09 15:47 ` Linus Torvalds
2011-06-09 15:51 ` Ingo Molnar
2011-06-09 16:25 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610093049.GG27280@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@die-jansens.de \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.