All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux-MM <linux-mm@kvack.org>,
	Linux-Netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>, Neil Brown <neilb@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Mel Gorman <mgorman@suse.de>
Subject: [PATCH 01/14] mm: Serialize access to min_free_kbytes
Date: Mon, 20 Jun 2011 14:12:07 +0100	[thread overview]
Message-ID: <1308575540-25219-2-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1308575540-25219-1-git-send-email-mgorman@suse.de>

There is a race between the min_free_kbytes sysctl, memory hotplug
and transparent hugepage support enablement.  Memory hotplug uses a
zonelists_mutex to avoid a race when building zonelists. Reuse it to
serialise watermark updates.

[a.p.zijlstra@chello.nl: Older patch fixed the race with spinlock]
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/page_alloc.c |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4e8985a..a327a72 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5045,14 +5045,7 @@ static void setup_per_zone_lowmem_reserve(void)
 	calculate_totalreserve_pages();
 }
 
-/**
- * setup_per_zone_wmarks - called when min_free_kbytes changes
- * or when memory is hot-{added|removed}
- *
- * Ensures that the watermark[min,low,high] values for each zone are set
- * correctly with respect to min_free_kbytes.
- */
-void setup_per_zone_wmarks(void)
+static void __setup_per_zone_wmarks(void)
 {
 	unsigned long pages_min = min_free_kbytes >> (PAGE_SHIFT - 10);
 	unsigned long lowmem_pages = 0;
@@ -5107,6 +5100,20 @@ void setup_per_zone_wmarks(void)
 	calculate_totalreserve_pages();
 }
 
+/**
+ * setup_per_zone_wmarks - called when min_free_kbytes changes
+ * or when memory is hot-{added|removed}
+ *
+ * Ensures that the watermark[min,low,high] values for each zone are set
+ * correctly with respect to min_free_kbytes.
+ */
+void setup_per_zone_wmarks(void)
+{
+	mutex_lock(&zonelists_mutex);
+	__setup_per_zone_wmarks();
+	mutex_unlock(&zonelists_mutex);
+}
+
 /*
  * The inactive anon list should be small enough that the VM never has to
  * do too much work, but large enough that each inactive page has a chance
-- 
1.7.3.4


WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linux-MM <linux-mm@kvack.org>,
	Linux-Netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	David Miller <davem@davemloft.net>, Neil Brown <neilb@suse.de>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Mel Gorman <mgorman@suse.de>
Subject: [PATCH 01/14] mm: Serialize access to min_free_kbytes
Date: Mon, 20 Jun 2011 14:12:07 +0100	[thread overview]
Message-ID: <1308575540-25219-2-git-send-email-mgorman@suse.de> (raw)
In-Reply-To: <1308575540-25219-1-git-send-email-mgorman@suse.de>

There is a race between the min_free_kbytes sysctl, memory hotplug
and transparent hugepage support enablement.  Memory hotplug uses a
zonelists_mutex to avoid a race when building zonelists. Reuse it to
serialise watermark updates.

[a.p.zijlstra@chello.nl: Older patch fixed the race with spinlock]
Signed-off-by: Mel Gorman <mgorman@suse.de>
---
 mm/page_alloc.c |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 4e8985a..a327a72 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5045,14 +5045,7 @@ static void setup_per_zone_lowmem_reserve(void)
 	calculate_totalreserve_pages();
 }
 
-/**
- * setup_per_zone_wmarks - called when min_free_kbytes changes
- * or when memory is hot-{added|removed}
- *
- * Ensures that the watermark[min,low,high] values for each zone are set
- * correctly with respect to min_free_kbytes.
- */
-void setup_per_zone_wmarks(void)
+static void __setup_per_zone_wmarks(void)
 {
 	unsigned long pages_min = min_free_kbytes >> (PAGE_SHIFT - 10);
 	unsigned long lowmem_pages = 0;
@@ -5107,6 +5100,20 @@ void setup_per_zone_wmarks(void)
 	calculate_totalreserve_pages();
 }
 
+/**
+ * setup_per_zone_wmarks - called when min_free_kbytes changes
+ * or when memory is hot-{added|removed}
+ *
+ * Ensures that the watermark[min,low,high] values for each zone are set
+ * correctly with respect to min_free_kbytes.
+ */
+void setup_per_zone_wmarks(void)
+{
+	mutex_lock(&zonelists_mutex);
+	__setup_per_zone_wmarks();
+	mutex_unlock(&zonelists_mutex);
+}
+
 /*
  * The inactive anon list should be small enough that the VM never has to
  * do too much work, but large enough that each inactive page has a chance
-- 
1.7.3.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-06-20 13:12 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-20 13:12 [PATCH 00/14] Swap-over-NBD without deadlocking v5 Mel Gorman
2011-06-20 13:12 ` Mel Gorman
2011-06-20 13:12 ` Mel Gorman [this message]
2011-06-20 13:12   ` [PATCH 01/14] mm: Serialize access to min_free_kbytes Mel Gorman
2011-07-06 23:44   ` Andrew Morton
2011-07-06 23:44     ` Andrew Morton
2011-07-07  9:17     ` Mel Gorman
2011-07-07  9:17       ` Mel Gorman
2011-06-20 13:12 ` [PATCH 02/14] mm: sl[au]b: Add knowledge of PFMEMALLOC reserve pages Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 03/14] mm: Introduce __GFP_MEMALLOC to allow access to emergency reserves Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 04/14] mm: allow PF_MEMALLOC from softirq context Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 05/14] mm: Ignore mempolicies when using ALLOC_NO_WATERMARK Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 06/14] net: Introduce sk_allocation() to allow addition of GFP flags depending on the individual socket Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 07/14] netvm: Allow the use of __GFP_MEMALLOC by specific sockets Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 08/14] netvm: Allow skb allocation to use PFMEMALLOC reserves Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 09/14] netvm: Propagate page->pfmemalloc to skb Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 11/14] mm: Micro-optimise slab to avoid a function call Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 12/14] nbd: Set SOCK_MEMALLOC for access to PFMEMALLOC reserves Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 13/14] mm: Throttle direct reclaimers if PF_MEMALLOC reserves are low and swap is backed by network storage Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-06-20 13:12 ` [PATCH 14/14] mm: Account for the number of times direct reclaimers get throttled Mel Gorman
2011-06-20 13:12   ` Mel Gorman
2011-07-06 23:51 ` [PATCH 00/14] Swap-over-NBD without deadlocking v5 Andrew Morton
2011-07-06 23:51   ` Andrew Morton
2011-07-07  9:47   ` Mel Gorman
2011-07-07  9:47     ` Mel Gorman
2011-07-07 12:58     ` Christoph Hellwig
2011-07-07 12:58       ` Christoph Hellwig
2011-07-15 14:10       ` Mel Gorman
2011-07-15 14:10         ` Mel Gorman
2011-07-15 15:27         ` Christoph Hellwig
2011-07-15 15:27           ` Christoph Hellwig
  -- strict thread matches above, loose matches on Subject: below --
2011-10-06 12:41 [PATCH 00/14] Swap-over-NBD without deadlocking V7 Mel Gorman
2011-10-06 12:41 ` [PATCH 01/14] mm: Serialize access to min_free_kbytes Mel Gorman
2011-10-06 12:41   ` Mel Gorman
2011-09-09 10:57 [PATCH 00/14] Swap-over-NBD without deadlocking v6 Mel Gorman
2011-09-09 10:57 ` [PATCH 01/14] mm: Serialize access to min_free_kbytes Mel Gorman
2011-09-09 10:57   ` Mel Gorman
2011-06-09  8:02 [PATCH 00/14] Swap-over-NBD without deadlocking v4r3 Mel Gorman
2011-06-09  8:02 ` [PATCH 01/14] mm: Serialize access to min_free_kbytes Mel Gorman
2011-06-09  8:02   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308575540-25219-2-git-send-email-mgorman@suse.de \
    --to=mgorman@suse.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=neilb@suse.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.