* [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n
@ 2011-06-21 6:12 Stephen Boyd
2011-06-21 6:41 ` Américo Wang
2011-06-21 14:43 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2011-06-21 6:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Randy Dunlap
If CONFIG_IKCONFIG=m but CONFIG_IKCONFIG_PROC=n we get a module that has
no MODULE_LICENSE definition. Move the MODULE_*() definitions outside
the CONFIG_IKCONFIG_PROC #ifdef to prevent this configuration from
tainting the kernel.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>
---
kernel/configs.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/configs.c b/kernel/configs.c
index b4066b4..42e8fa0 100644
--- a/kernel/configs.c
+++ b/kernel/configs.c
@@ -92,8 +92,8 @@ static void __exit ikconfig_cleanup(void)
module_init(ikconfig_init);
module_exit(ikconfig_cleanup);
+#endif /* CONFIG_IKCONFIG_PROC */
+
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Randy Dunlap");
MODULE_DESCRIPTION("Echo the kernel .config file used to build the kernel");
-
-#endif /* CONFIG_IKCONFIG_PROC */
--
1.7.5.rc2.4.g4d8b3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n
2011-06-21 6:12 [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n Stephen Boyd
@ 2011-06-21 6:41 ` Américo Wang
2011-06-21 14:43 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Américo Wang @ 2011-06-21 6:41 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, Andrew Morton, Randy Dunlap
On Tue, Jun 21, 2011 at 2:12 PM, Stephen Boyd <bebarino@gmail.com> wrote:
> If CONFIG_IKCONFIG=m but CONFIG_IKCONFIG_PROC=n we get a module that has
> no MODULE_LICENSE definition. Move the MODULE_*() definitions outside
> the CONFIG_IKCONFIG_PROC #ifdef to prevent this configuration from
> tainting the kernel.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n
2011-06-21 6:12 [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n Stephen Boyd
2011-06-21 6:41 ` Américo Wang
@ 2011-06-21 14:43 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2011-06-21 14:43 UTC (permalink / raw)
To: Stephen Boyd; +Cc: linux-kernel, Andrew Morton
On Mon, 20 Jun 2011 23:12:27 -0700 Stephen Boyd wrote:
> If CONFIG_IKCONFIG=m but CONFIG_IKCONFIG_PROC=n we get a module that has
> no MODULE_LICENSE definition. Move the MODULE_*() definitions outside
> the CONFIG_IKCONFIG_PROC #ifdef to prevent this configuration from
> tainting the kernel.
>
> Signed-off-by: Stephen Boyd <bebarino@gmail.com>
> Cc: Randy Dunlap <rdunlap@xenotime.net>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> kernel/configs.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/configs.c b/kernel/configs.c
> index b4066b4..42e8fa0 100644
> --- a/kernel/configs.c
> +++ b/kernel/configs.c
> @@ -92,8 +92,8 @@ static void __exit ikconfig_cleanup(void)
> module_init(ikconfig_init);
> module_exit(ikconfig_cleanup);
>
> +#endif /* CONFIG_IKCONFIG_PROC */
> +
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Randy Dunlap");
> MODULE_DESCRIPTION("Echo the kernel .config file used to build the kernel");
> -
> -#endif /* CONFIG_IKCONFIG_PROC */
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-21 14:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-21 6:12 [PATCH] configs: Include MODULE_*() when CONFIG_IKCONFIG_PROC=n Stephen Boyd
2011-06-21 6:41 ` Américo Wang
2011-06-21 14:43 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.