From: Luciano Coelho <coelho@ti.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jesper Juhl <jj@chaosbits.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] net, wireless: Don't return uninitialized in __cfg80211_stop_sched_scan()
Date: Wed, 29 Jun 2011 23:33:50 +0300 [thread overview]
Message-ID: <1309379630.1514.122.camel@cumari> (raw)
In-Reply-To: <1309379244.4071.7.camel@jlt3.sipsolutions.net>
On Wed, 2011-06-29 at 22:27 +0200, Johannes Berg wrote:
> On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote:
> > If the 'driver_initiated' function argument to
> > __cfg80211_stop_sched_scan() is not 0 then we'll return an
> > uninitialized 'ret' from the function.
>
> 'err'. I also dislike the initialisation, can we just replace the
> "return err;" at the end of the function with "return 0;" instead?
Luckily we were never using the return value when passing
driver_initiate =- false.
And I agree with you, there's no use to return err at the end. Better
to simply return 0.
> Luca, should it maybe be return -ENOENT anyway in the !sched_scan_req
> case?
We could do that. I had just thought that stopping a scan that is not
running would just be a NOP, but if you prefer to return an error in
that case, I can do it.
--
Cheers,
Luca.
WARNING: multiple messages have this Message-ID (diff)
From: Luciano Coelho <coelho-l0cyMroinI0@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: Jesper Juhl <jj-IYz4IdjRLj0sV2N9l4h3zg@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH] net, wireless: Don't return uninitialized in __cfg80211_stop_sched_scan()
Date: Wed, 29 Jun 2011 23:33:50 +0300 [thread overview]
Message-ID: <1309379630.1514.122.camel@cumari> (raw)
In-Reply-To: <1309379244.4071.7.camel-8upI4CBIZJIJvtFkdXX2HixXY32XiHfO@public.gmane.org>
On Wed, 2011-06-29 at 22:27 +0200, Johannes Berg wrote:
> On Wed, 2011-06-29 at 22:13 +0200, Jesper Juhl wrote:
> > If the 'driver_initiated' function argument to
> > __cfg80211_stop_sched_scan() is not 0 then we'll return an
> > uninitialized 'ret' from the function.
>
> 'err'. I also dislike the initialisation, can we just replace the
> "return err;" at the end of the function with "return 0;" instead?
Luckily we were never using the return value when passing
driver_initiate =- false.
And I agree with you, there's no use to return err at the end. Better
to simply return 0.
> Luca, should it maybe be return -ENOENT anyway in the !sched_scan_req
> case?
We could do that. I had just thought that stopping a scan that is not
running would just be a NOP, but if you prefer to return an error in
that case, I can do it.
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-06-29 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 20:13 [PATCH] net, wireless: Don't return uninitialized in __cfg80211_stop_sched_scan() Jesper Juhl
2011-06-29 20:13 ` Jesper Juhl
2011-06-29 20:27 ` Johannes Berg
2011-06-29 20:27 ` Johannes Berg
2011-06-29 20:33 ` Luciano Coelho [this message]
2011-06-29 20:33 ` Luciano Coelho
2011-06-29 20:42 ` Jesper Juhl
2011-06-29 20:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309379630.1514.122.camel@cumari \
--to=coelho@ti.com \
--cc=davem@davemloft.net \
--cc=jj@chaosbits.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.