From: Artem Bityutskiy <dedekind1@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, b35362@freescale.com,
dwmw2@infradead.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] mtd/nand : workaround for Freescale FCM to support large-page Nand chip
Date: Thu, 30 Jun 2011 14:51:08 +0300 [thread overview]
Message-ID: <1309434673.23597.176.camel@sauron> (raw)
In-Reply-To: <20110629114329.154aaef2@schlenkerla.am.freescale.net>
On Wed, 2011-06-29 at 11:43 -0500, Scott Wood wrote:
> On Wed, 29 Jun 2011 09:22:04 +0300
> Artem Bityutskiy <dedekind1@gmail.com> wrote:
>
> > On Tue, 2011-06-28 at 09:50 +0800, b35362@freescale.com wrote:
> > > + /* Hack for supporting the flash chip whose writesize is
> > > + * larger than 2K bytes.
> > > + */
> >
> > Please, use proper kernel multi-line comments. Please, make sure
> > checkpatch.pl does not generate 13 errors with this patch.
>
> Most of the checkpatch complaints are about existing style in the file --
> particularly, the use of tabs only for indentation, with spaces used for
> alignment beyond the indentation point.
OK, fair enough, but the multi-line comment is a valid complain,
although minor. And you guys could just fix the style issues as well in
a separate patch-set.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2011-06-30 11:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 1:50 [PATCH 1/2] mtd/nand : don't free the global data fsl_lbc_ctrl_dev->nand in fsl_elbc_chip_remove() b35362
2011-06-28 1:50 ` [PATCH 2/2] mtd/nand : workaround for Freescale FCM to support large-page Nand chip b35362
2011-06-28 1:50 ` b35362
2011-06-28 15:35 ` [PATCH 2/2] mtd/nand : workaround for Freescale FCM to supportlarge-page " Mike Hench
2011-06-28 15:35 ` Mike Hench
2011-06-28 16:30 ` Scott Wood
2011-07-05 23:08 ` [U-Boot] " Matthew L. Creech
2011-07-05 23:13 ` Scott Wood
2011-07-06 0:04 ` Mike Hench
2011-07-08 19:10 ` Mike Hench
2011-07-08 19:17 ` Scott Wood
2011-06-29 6:22 ` [PATCH 2/2] mtd/nand : workaround for Freescale FCM to support large-page " Artem Bityutskiy
2011-06-29 6:22 ` Artem Bityutskiy
2011-06-29 16:43 ` Scott Wood
2011-06-30 11:51 ` Artem Bityutskiy [this message]
2011-06-29 6:20 ` [PATCH 1/2] mtd/nand : don't free the global data fsl_lbc_ctrl_dev->nand in fsl_elbc_chip_remove() Artem Bityutskiy
2011-06-29 16:45 ` Scott Wood
2011-06-30 11:53 ` Artem Bityutskiy
2011-06-30 16:26 ` Scott Wood
2011-07-01 5:40 ` Artem Bityutskiy
2011-07-01 16:14 ` Scott Wood
2011-07-06 6:46 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309434673.23597.176.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b35362@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.