From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Benoit Cousson <b-cousson@ti.com>
Cc: paul@pwsan.com, rnayak@ti.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 17/18] OMAP4: hwmod data: Modify DSS opt clocks
Date: Sat, 02 Jul 2011 12:13:57 +0300 [thread overview]
Message-ID: <1309598037.1846.3.camel@deskari> (raw)
In-Reply-To: <1309552901-8944-18-git-send-email-b-cousson@ti.com>
Hi Benoit,
On Fri, 2011-07-01 at 22:41 +0200, Benoit Cousson wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Add missing DSS optional clocks to HWMOD data for OMAP4xxx.
>
> Add HWMOD_CONTROL_OPT_CLKS_IN_RESET flag for dispc to fix dispc reset.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> [b-cousson@ti.com: Remove a comment and update the subject]
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
This patch adds "fck" opt-clocks for DSS. After your patch set
for_3.1/5_auto_fck_clkdev, in which you create "fck" automatically, I
see:
[ 0.218231] omap_device: omapdss_dss: fck already exist
[ 0.218261] omap_device: omapdss_dss: fck already exist
[ 0.218261] omap_device: omapdss_dss: sys_clk already exist
[ 0.218261] omap_device: omapdss_dss: tv_clk already exist
[ 0.218322] omap_device: omapdss_dss: video_clk already exist
[ 0.218627] omap_device: omapdss_dispc: fck already exist
[ 0.219329] omap_device: omapdss_venc: fck already exist
[ 0.219635] omap_device: omapdss_dsi1: fck already exist
[ 0.219970] omap_device: omapdss_dsi2: fck already exist
[ 0.220336] omap_device: omapdss_hdmi: fck already exist
So I think the "fck" clocks in this patch should be removed. I only
added them for compatibility, as I didn't have the automatic "fck"
creation patch in my tree.
Also, either you didn't email the patch set in
for_3.1/5_auto_fck_clkdev, or I'm just blind...
Tomi
WARNING: multiple messages have this Message-ID (diff)
From: tomi.valkeinen@ti.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 17/18] OMAP4: hwmod data: Modify DSS opt clocks
Date: Sat, 02 Jul 2011 12:13:57 +0300 [thread overview]
Message-ID: <1309598037.1846.3.camel@deskari> (raw)
In-Reply-To: <1309552901-8944-18-git-send-email-b-cousson@ti.com>
Hi Benoit,
On Fri, 2011-07-01 at 22:41 +0200, Benoit Cousson wrote:
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Add missing DSS optional clocks to HWMOD data for OMAP4xxx.
>
> Add HWMOD_CONTROL_OPT_CLKS_IN_RESET flag for dispc to fix dispc reset.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> [b-cousson at ti.com: Remove a comment and update the subject]
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
This patch adds "fck" opt-clocks for DSS. After your patch set
for_3.1/5_auto_fck_clkdev, in which you create "fck" automatically, I
see:
[ 0.218231] omap_device: omapdss_dss: fck already exist
[ 0.218261] omap_device: omapdss_dss: fck already exist
[ 0.218261] omap_device: omapdss_dss: sys_clk already exist
[ 0.218261] omap_device: omapdss_dss: tv_clk already exist
[ 0.218322] omap_device: omapdss_dss: video_clk already exist
[ 0.218627] omap_device: omapdss_dispc: fck already exist
[ 0.219329] omap_device: omapdss_venc: fck already exist
[ 0.219635] omap_device: omapdss_dsi1: fck already exist
[ 0.219970] omap_device: omapdss_dsi2: fck already exist
[ 0.220336] omap_device: omapdss_hdmi: fck already exist
So I think the "fck" clocks in this patch should be removed. I only
added them for compatibility, as I didn't have the automatic "fck"
creation patch in my tree.
Also, either you didn't email the patch set in
for_3.1/5_auto_fck_clkdev, or I'm just blind...
Tomi
next prev parent reply other threads:[~2011-07-02 9:14 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 20:41 [PATCH v2 00/18] OMAP4: PM data big spring cleanup and fixes Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 01/18] OMAP4: cm: Remove RESTORE macros to avoid access from SW Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 02/18] OMAP4: prcm_mpu: Fix indent in few macros Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 03/18] OMAP4: clockdomain data: Fix data order and wrong name Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 04/18] OMAP4: clock data: Add sddiv to USB DPLL Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 05/18] OMAP4: clock data: Remove usb_host_fs clkdev with NULL dev Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 06/18] OMAP4: clock data: Re-order some clock nodes and structure fields Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 07/18] OMAP4: clock data: Fix max mult and div for USB DPLL Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 08/18] OMAP4: clock data: Rename clock flags from 443X to 44XX Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-10 2:03 ` Paul Walmsley
2011-07-10 2:03 ` Paul Walmsley
2011-07-01 20:41 ` [PATCH v2 09/18] OMAP4: clock data: Remove McASP2, McASP3 and MMC6 clocks Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-06 6:59 ` Paul Walmsley
2011-07-06 6:59 ` Paul Walmsley
2011-07-01 20:41 ` [PATCH v2 10/18] OMAP4: clock data: Remove UNIPRO clock nodes Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-06 7:00 ` Paul Walmsley
2011-07-06 7:00 ` Paul Walmsley
2011-07-01 20:41 ` [PATCH v2 11/18] OMAP4: clock data: Add missing divider selection for auxclks Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 12/18] OMAP4: prcm: Remove references to non-existant peripherals Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 13/18] OMAP4: hwmod data: Fix L3 interconnect data order and alignement Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 14/18] OMAP4: hwmod data: Remove un-needed parens Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 15/18] OMAP4: hwmod data: Fix bad alignement Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 16/18] OMAP4: hwmod data: Replace CHIP_IS_OMAP4430 by OMAP44XX Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-01 20:41 ` [PATCH v2 17/18] OMAP4: hwmod data: Modify DSS opt clocks Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-02 9:13 ` Tomi Valkeinen [this message]
2011-07-02 9:13 ` Tomi Valkeinen
2011-07-02 9:36 ` Tomi Valkeinen
2011-07-02 9:36 ` Tomi Valkeinen
2011-07-09 8:26 ` Paul Walmsley
2011-07-09 8:26 ` Paul Walmsley
2011-07-09 8:24 ` Paul Walmsley
2011-07-09 8:24 ` Paul Walmsley
2011-07-01 20:41 ` [PATCH v2 18/18] OMAP4: hwmod data: Change DSS main_clk scheme Benoit Cousson
2011-07-01 20:41 ` Benoit Cousson
2011-07-06 7:19 ` [PATCH v2 00/18] OMAP4: PM data big spring cleanup and fixes Paul Walmsley
2011-07-06 7:19 ` Paul Walmsley
2011-07-06 19:31 ` Rajendra Nayak
2011-07-06 19:31 ` Rajendra Nayak
2011-07-07 6:01 ` Tony Lindgren
2011-07-07 6:01 ` Tony Lindgren
2011-07-07 7:24 ` Martin Fouts
2011-07-07 7:24 ` Martin Fouts
2011-07-07 12:10 ` Tony Lindgren
2011-07-07 12:10 ` Tony Lindgren
2011-07-07 14:30 ` Martin Fouts
2011-07-07 14:30 ` Martin Fouts
2011-07-07 15:48 ` Tony Lindgren
2011-07-07 15:48 ` Tony Lindgren
2011-07-08 7:33 ` Paul Walmsley
2011-07-08 7:33 ` Paul Walmsley
2011-07-08 7:11 ` Paul Walmsley
2011-07-08 7:11 ` Paul Walmsley
2011-07-08 7:22 ` Rajendra Nayak
2011-07-08 7:22 ` Rajendra Nayak
2011-07-08 7:32 ` Tony Lindgren
2011-07-08 7:32 ` Tony Lindgren
2011-07-08 9:04 ` Peter De Schrijver
2011-07-28 17:08 ` Cousson, Benoit
2011-07-28 17:08 ` Cousson, Benoit
2011-07-08 6:39 ` Paul Walmsley
2011-07-08 6:39 ` Paul Walmsley
2011-07-08 13:16 ` Tony Lindgren
2011-07-08 13:16 ` Tony Lindgren
2011-07-08 16:56 ` Rajendra Nayak
2011-07-08 16:56 ` Rajendra Nayak
2011-07-06 22:41 ` Paul Walmsley
2011-07-06 22:41 ` Paul Walmsley
2011-07-28 17:11 ` Cousson, Benoit
2011-07-28 17:11 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309598037.1846.3.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.