* [PATCH] drivers/leds/leds-netxbig: make LEDS_NETXBIG depend on LEDS_CLASS
@ 2011-07-09 15:07 Axel Lin
2011-07-09 15:32 ` Simon Guinot
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-07-09 15:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Simon Guinot, Richard Purdie, Andrew Morton
We call led_classdev_register/led_classdev_unregister in
create_netxbig_led/delete_netxbig_led, thus make LEDS_NETXBIG
depend on LEDS_CLASS.
This patch fixes below build error if LEDS_CLASS is not configured.
LD .tmp_vmlinux1
drivers/built-in.o: In function `create_netxbig_led':
drivers/leds/leds-netxbig.c:350: undefined reference to `led_classdev_register'
drivers/leds/leds-netxbig.c:361: undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function `delete_netxbig_led':
drivers/leds/leds-netxbig.c:313: undefined reference to `led_classdev_unregister'
make: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/leds/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 6cb0708..8974d27 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -357,6 +357,7 @@ config LEDS_NS2
config LEDS_NETXBIG
tristate "LED support for Big Network series LEDs"
depends on MACH_NET2BIG_V2 || MACH_NET5BIG_V2
+ depends on LEDS_CLASS
default y
help
This option enable support for LEDs found on the LaCie 2Big
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/leds/leds-netxbig: make LEDS_NETXBIG depend on LEDS_CLASS
2011-07-09 15:07 [PATCH] drivers/leds/leds-netxbig: make LEDS_NETXBIG depend on LEDS_CLASS Axel Lin
@ 2011-07-09 15:32 ` Simon Guinot
0 siblings, 0 replies; 2+ messages in thread
From: Simon Guinot @ 2011-07-09 15:32 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Simon Guinot, Richard Purdie, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Sat, Jul 09, 2011 at 11:07:18PM +0800, Axel Lin wrote:
> We call led_classdev_register/led_classdev_unregister in
> create_netxbig_led/delete_netxbig_led, thus make LEDS_NETXBIG
> depend on LEDS_CLASS.
>
> This patch fixes below build error if LEDS_CLASS is not configured.
>
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `create_netxbig_led':
> drivers/leds/leds-netxbig.c:350: undefined reference to `led_classdev_register'
> drivers/leds/leds-netxbig.c:361: undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `delete_netxbig_led':
> drivers/leds/leds-netxbig.c:313: undefined reference to `led_classdev_unregister'
> make: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Simon Guinot <sguinot@lacie.com>
Thanks,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-09 15:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-09 15:07 [PATCH] drivers/leds/leds-netxbig: make LEDS_NETXBIG depend on LEDS_CLASS Axel Lin
2011-07-09 15:32 ` Simon Guinot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.