[PATCH 1/4] b43: HT-PHY: fix masks in radio ctl

All of lore.kernel.org
 help / color / mirror / Atom feed

From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 1/4] b43: HT-PHY: fix masks in radio ctl
Date: Sun, 17 Jul 2011 10:30:31 +0200	[thread overview]
Message-ID: <1310891434-3537-1-git-send-email-zajec5@gmail.com> (raw)

Old masks were causing ugly, delayed lock ups.

Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
 drivers/net/wireless/b43/phy_ht.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_ht.c b/drivers/net/wireless/b43/phy_ht.c
index 2982103..0cc293a 100644
--- a/drivers/net/wireless/b43/phy_ht.c
+++ b/drivers/net/wireless/b43/phy_ht.c
@@ -277,12 +277,12 @@ static void b43_phy_ht_op_software_rfkill(struct b43_wldev *dev,
 		b43err(dev->wl, "MAC not suspended\n");
 
 	if (blocked) {
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
 	} else {
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
-		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, ~0, 0x1);
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
-		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, ~0, 0x2);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
+		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, 0, 0x1);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
+		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, 0, 0x2);
 
 		if (dev->phy.radio_ver == 0x2059)
 			b43_radio_2059_init(dev);
-- 
1.7.3.4

WARNING: multiple messages have this Message-ID (diff)

From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Cc: b43-dev@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH 1/4] b43: HT-PHY: fix masks in radio ctl
Date: Sun, 17 Jul 2011 10:30:31 +0200	[thread overview]
Message-ID: <1310891434-3537-1-git-send-email-zajec5@gmail.com> (raw)

Old masks were causing ugly, delayed lock ups.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
 drivers/net/wireless/b43/phy_ht.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_ht.c b/drivers/net/wireless/b43/phy_ht.c
index 2982103..0cc293a 100644
--- a/drivers/net/wireless/b43/phy_ht.c
+++ b/drivers/net/wireless/b43/phy_ht.c
@@ -277,12 +277,12 @@ static void b43_phy_ht_op_software_rfkill(struct b43_wldev *dev,
 		b43err(dev->wl, "MAC not suspended\n");
 
 	if (blocked) {
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
 	} else {
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
-		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, ~0, 0x1);
-		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, ~0);
-		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, ~0, 0x2);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
+		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, 0, 0x1);
+		b43_phy_mask(dev, B43_PHY_HT_RF_CTL1, 0);
+		b43_phy_maskset(dev, B43_PHY_HT_RF_CTL1, 0, 0x2);
 
 		if (dev->phy.radio_ver == 0x2059)
 			b43_radio_2059_init(dev);
-- 
1.7.3.4

next             reply	other threads:[~2011-07-17  8:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-17  8:30 Rafał Miłecki [this message]
2011-07-17  8:30 ` [PATCH 1/4] b43: HT-PHY: fix masks in radio ctl Rafał Miłecki
2011-07-17  8:30 ` [PATCH 2/4] b43: HT-PHY: switch to channel after enabling radio Rafał Miłecki
2011-07-17  8:30   ` Rafał Miłecki
2011-07-17  8:30 ` [PATCH 3/4] b43: HT-PHY: find channel entry with regs data Rafał Miłecki
2011-07-17  8:30   ` Rafał Miłecki
2011-07-17  8:30 ` [PATCH 4/4] b43: HT-PHY: fix typo in 0x2059 radio init Rafał Miłecki
2011-07-17  8:30   ` Rafał Miłecki
2011-07-17  8:43 ` [PATCH 1/4] b43: HT-PHY: fix masks in radio ctl Michael Büsch
2011-07-17  8:43   ` Michael Büsch
2011-07-17 15:05   ` Larry Finger
2011-07-17 15:05     ` Larry Finger
2011-07-17 16:42   ` Rafał Miłecki
2011-07-17 16:42     ` Rafał Miłecki
2011-07-17 16:56   ` Rafał Miłecki
2011-07-17 16:56     ` Rafał Miłecki
  -- strict thread matches above, loose matches on Subject: below --
2011-07-18  0:13 Rafał Miłecki
2011-07-18  0:13 ` Rafał Miłecki

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:2982103 dfblob:0cc293a dfblob:2982103 dfblob:0cc293a )
 OR (
bs:"[PATCH 1/4] b43: HT-PHY: fix masks in radio ctl" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310891434-3537-1-git-send-email-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.