All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME
Date: Mon, 25 Jul 2011 10:57:40 -0500	[thread overview]
Message-ID: <1311609460.2914.25.camel@doink> (raw)
In-Reply-To: <20110724113724.GC26332@infradead.org>

On Sun, 2011-07-24 at 07:37 -0400, Christoph Hellwig wrote:
> On Fri, Jul 22, 2011 at 02:49:41PM -0500, Alex Elder wrote:
> > On Thu, 2011-07-21 at 17:34 -0700, Chandra Seetharaman wrote:
> > > Remove the definition and usages of the macro XFS_BUFTARG_NAME.
> > > 
> > > Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > 
> > 
> > Wow, I hadn't looked at the definition of
> > xfs_buf_target_name() before.  It's not safe
> > (using a pointer to since-released stack space),
> > though in practice it's going to be fine.
> > 
> > Defining it as an inline function with a static
> > buffer would at least avoid that, though it
> > means it's not reentrant either.
> 
> IMHO the right fix is to just kill it off entirely.  All XFS messages
> now have the filesystem name prefixed to them, and while we can have
> up to three devices, all these error messages can only hit either
> the main or the log device, and it's obvious from the context which
> one we did hit.

That's an even better idea.  I was only reacting to the
code in front of me, but yes, removing it entirely
would be good.

For now though, I intend to commit this (in its now updated
form).  It can be removed as a separate patch.

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-25 15:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  0:32 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 01/12] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 19:37   ` Alex Elder
2011-07-22  0:32 ` [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:49     ` Chandra Seetharaman
2011-07-22 21:10       ` Alex Elder
2011-07-22 21:30         ` Alex Elder
2011-07-22 21:31         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 04/12] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 05/12] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 06/12] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:50     ` Chandra Seetharaman
2011-07-24 11:35     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder
2011-07-25 16:25         ` Christoph Hellwig
2011-07-25 16:58           ` Alex Elder
2011-07-25 22:18         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 09/12] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:51     ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 10/12] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:34 ` [PATCH 11/12] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 19:46   ` Alex Elder
2011-07-22  0:34 ` [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-22 19:49   ` Alex Elder
2011-07-22 21:23     ` Chandra Seetharaman
2011-07-22 21:26       ` Chandra Seetharaman
2011-07-24 11:37     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder [this message]
2011-07-25 16:26         ` Christoph Hellwig
2011-07-25 22:18         ` Chandra Seetharaman
  -- strict thread matches above, loose matches on Subject: below --
2011-07-16  1:21 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-16  1:22 ` [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-16  2:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311609460.2914.25.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.