All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR
Date: Mon, 25 Jul 2011 11:58:42 -0500	[thread overview]
Message-ID: <1311613122.2914.35.camel@doink> (raw)
In-Reply-To: <20110725162513.GA2434@infradead.org>

On Mon, 2011-07-25 at 12:25 -0400, Christoph Hellwig wrote:
> On Mon, Jul 25, 2011 at 10:57:36AM -0500, Alex Elder wrote:
> > > Btw, nice follow-on cleanups would be to kill off the xfs_caddr_t and
> > > __psint_t/__psunsigned_t types entirely.
> > 
> > Yes.  What do you suggest to use for a pointer-sized
> > type?  Just cast to (long) and rely on the usual arithmetic
> > conversions to do the right thing?
> 
> The correct C99 type is (u)intptr_t.  In the kernel we only have
> uintptr_t, with ACPI defining a local version of intptr_t.  I'd suggest
> trying to stick to uintptr_t if we can, and if we really need a signed
> version add intptr_t to the common headers - it can unconditionally be
> typedef to long in Linux anyway.

I *knew* there was a standard type but I couldn't
remember what it was called.  I even scanned through
my C spec but gave up looking pretty quickly.  I
think I had "size" somehow stuck in my mind and that
didn't help.

					-Alex

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-25 16:58 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22  0:32 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 01/12] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 19:37   ` Alex Elder
2011-07-22  0:32 ` [PATCH 02/12] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-22  0:32 ` [PATCH 03/12] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:49     ` Chandra Seetharaman
2011-07-22 21:10       ` Alex Elder
2011-07-22 21:30         ` Alex Elder
2011-07-22 21:31         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 04/12] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 05/12] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 06/12] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:33 ` [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:50     ` Chandra Seetharaman
2011-07-24 11:35     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder
2011-07-25 16:25         ` Christoph Hellwig
2011-07-25 16:58           ` Alex Elder [this message]
2011-07-25 22:18         ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 09/12] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 20:51     ` Chandra Seetharaman
2011-07-22  0:33 ` [PATCH 10/12] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22  0:34 ` [PATCH 11/12] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 19:38   ` Alex Elder
2011-07-22 19:46   ` Alex Elder
2011-07-22  0:34 ` [PATCH 12/12] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-22 19:49   ` Alex Elder
2011-07-22 21:23     ` Chandra Seetharaman
2011-07-22 21:26       ` Chandra Seetharaman
2011-07-24 11:37     ` Christoph Hellwig
2011-07-25 15:57       ` Alex Elder
2011-07-25 16:26         ` Christoph Hellwig
2011-07-25 22:18         ` Chandra Seetharaman
  -- strict thread matches above, loose matches on Subject: below --
2011-07-16  1:21 [PATCH 00/12] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-16  1:21 ` [PATCH 08/12] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-16 16:44   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1311613122.2914.35.camel@doink \
    --to=aelder@sgi.com \
    --cc=hch@infradead.org \
    --cc=sekharan@us.ibm.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.