From: Helmut Schaa <helmut.schaa@googlemail.com>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: [PATCH 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests
Date: Tue, 26 Jul 2011 12:18:28 +0200 [thread overview]
Message-ID: <1311675508-29005-2-git-send-email-helmut.schaa@googlemail.com> (raw)
In-Reply-To: <1311675508-29005-1-git-send-email-helmut.schaa@googlemail.com>
According to 802.11-2007, 7.3.1.14 it is compliant to use a buf_size of
0 in ADDBA requests. But some devices (AVM Fritz Stick N) arn't able to
handle that correctly and will reply with an ADDBA reponse with a
buf_size of 0 which in turn will disallow BA sessions for these
devices.
To work around this problem, if the hardware doesn't specify an upper
limit for the number of subframes in an AMPDU send the maximum 0x40 by
default in ADDBA requests.
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
net/mac80211/agg-tx.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index b7075f3..13dbd00 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -345,7 +345,9 @@ void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid)
/* send AddBA request */
ieee80211_send_addba_request(sdata, sta->sta.addr, tid,
tid_tx->dialog_token, start_seq_num,
- local->hw.max_tx_aggregation_subframes,
+ local->hw.max_tx_aggregation_subframes ?
+ local->hw.max_tx_aggregation_subframes :
+ 0x40,
tid_tx->timeout);
}
--
1.7.3.4
next prev parent reply other threads:[~2011-07-26 10:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 10:18 [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Helmut Schaa
2011-07-26 10:18 ` Helmut Schaa [this message]
2011-08-05 8:15 ` [PATCH 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests Kalle Valo
2011-08-05 8:35 ` Helmut Schaa
2011-08-05 8:54 ` Kalle Valo
2011-08-05 9:46 ` [PATCHv2 " Helmut Schaa
2011-08-08 8:29 ` Johannes Berg
2011-08-08 8:40 ` Helmut Schaa
2011-08-08 8:46 ` Johannes Berg
2011-08-08 8:50 ` [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311675508-29005-2-git-send-email-helmut.schaa@googlemail.com \
--to=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.