From: Johannes Berg <johannes@sipsolutions.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@adurom.com>
Subject: Re: [PATCHv2 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests
Date: Mon, 08 Aug 2011 10:29:23 +0200 [thread overview]
Message-ID: <1312792163.4372.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1312537579-18950-1-git-send-email-helmut.schaa@googlemail.com> (sfid-20110805_114652_677728_F18AA5DB)
On Fri, 2011-08-05 at 11:46 +0200, Helmut Schaa wrote:
> According to 802.11-2007, 7.3.1.14 it is compliant to use a buf_size of
> 0 in ADDBA requests. But some devices (AVM Fritz Stick N) arn't able to
> handle that correctly and will reply with an ADDBA reponse with a
> buf_size of 0 which in turn will disallow BA sessions for these
> devices.
>
> To work around this problem, initialize hw.max_tx_aggregation_subframes
> to the maximum AMPDU buffer size 0x40.
>
> Using 0 as default for the bufsize was introduced in commit
> 5dd36bc933e8be84f8369ac64505a2938f9ce036 (mac80211: allow advertising
> correct maximum aggregate size).
So, are you saying the problem with getting 0 in replies is solved by
not sending 0 in requests?
Patch looks fine to me, but it's not clear to me that it's the only
thing needed?
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
next prev parent reply other threads:[~2011-08-08 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 10:18 [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Helmut Schaa
2011-07-26 10:18 ` [PATCH 2/2] mac80211: Don't use a buf_size=0 in ADDBA requests Helmut Schaa
2011-08-05 8:15 ` Kalle Valo
2011-08-05 8:35 ` Helmut Schaa
2011-08-05 8:54 ` Kalle Valo
2011-08-05 9:46 ` [PATCHv2 " Helmut Schaa
2011-08-08 8:29 ` Johannes Berg [this message]
2011-08-08 8:40 ` Helmut Schaa
2011-08-08 8:46 ` Johannes Berg
2011-08-08 8:50 ` [PATCH 1/2] mac80211: Stop TX BA session if buf_size is zero Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312792163.4372.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@adurom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.