From: Alex Elder <aelder@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync
Date: Tue, 26 Jul 2011 17:39:02 -0500 [thread overview]
Message-ID: <1311719942.11557.14.camel@doink> (raw)
In-Reply-To: <20110726150711.GB18000@infradead.org>
On Tue, 2011-07-26 at 11:07 -0400, Christoph Hellwig wrote:
> We need to take some locks to prevent new ioends from coming in when we wait
> for all existing ones to go away. Up to Linux 3.0 that was done using the
> i_mutex held by the VFS fsync code, but now that we are called without
> it we need to take care of it ourselves. Use the I/O lock instead of
> i_mutex just like we do in other places.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-26 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110726150633.GA17400@infradead.org>
2011-07-26 15:06 ` [PATCH 1/3] xfs: flag all buffers as metadata Christoph Hellwig
2011-07-26 22:38 ` Alex Elder
2011-07-26 22:40 ` Christoph Hellwig
2011-07-26 22:41 ` Alex Elder
2011-07-26 15:07 ` [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync Christoph Hellwig
2011-07-26 22:39 ` Alex Elder [this message]
2011-07-26 15:07 ` [PATCH 3/3] xfs: optimize the negative xattr caching Christoph Hellwig
2011-07-26 22:39 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311719942.11557.14.camel@doink \
--to=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.