All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <rob@ti.com>
To: dri-devel@lists.freedesktop.org
Cc: Rob Clark <rob@ti.com>, patches@linaro.org
Subject: [PATCH 3/9] drm/gma500: use common functions for mmap offset creation
Date: Thu,  4 Aug 2011 12:07:40 -0500	[thread overview]
Message-ID: <1312477672-32366-3-git-send-email-rob@ti.com> (raw)
In-Reply-To: <cover.1311034363.git.rob@ti.com>

---
 drivers/staging/gma500/psb_gem.c |   63 +------------------------------------
 1 files changed, 2 insertions(+), 61 deletions(-)

diff --git a/drivers/staging/gma500/psb_gem.c b/drivers/staging/gma500/psb_gem.c
index 76ff7ba..3a397f5 100644
--- a/drivers/staging/gma500/psb_gem.c
+++ b/drivers/staging/gma500/psb_gem.c
@@ -42,13 +42,7 @@ void psb_gem_free_object(struct drm_gem_object *obj)
 	struct gtt_range *gtt = container_of(obj, struct gtt_range, gem);
 	psb_gtt_free_range(obj->dev, gtt);
 	if (obj->map_list.map) {
-		/* Do things GEM should do for us */
-		struct drm_gem_mm *mm = obj->dev->mm_private;
-		struct drm_map_list *list = &obj->map_list;
-		drm_ht_remove_item(&mm->offset_hash, &list->hash);
-		drm_mm_put_block(list->file_offset_node);
-		kfree(list->map);
-		list->map = NULL;
+		drm_gem_free_mmap_offset(obj);
 	}
 	drm_gem_object_release(obj);
 }
@@ -60,59 +54,6 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data,
 }
 
 /**
- *	psb_gem_create_mmap_offset	-	invent an mmap offset
- *	@obj: our object
- *
- *	This is basically doing by hand a pile of ugly crap which should
- *	be done automatically by the GEM library code but isn't
- */
-static int psb_gem_create_mmap_offset(struct drm_gem_object *obj)
-{
-	struct drm_device *dev = obj->dev;
-	struct drm_gem_mm *mm = dev->mm_private;
-	struct drm_map_list *list;
-	struct drm_local_map *map;
-	int ret;
-
-	list = &obj->map_list;
-	list->map = kzalloc(sizeof(struct drm_map_list), GFP_KERNEL);
-	if (list->map == NULL)
-		return -ENOMEM;
-	map = list->map;
-	map->type = _DRM_GEM;
-	map->size = obj->size;
-	map->handle =obj;
-
-	list->file_offset_node = drm_mm_search_free(&mm->offset_manager,
-					obj->size / PAGE_SIZE, 0, 0);
-	if (!list->file_offset_node) {
-		DRM_ERROR("failed to allocate offset for bo %d\n", obj->name);
-		ret = -ENOSPC;
-		goto free_it;
-	}
-	list->file_offset_node = drm_mm_get_block(list->file_offset_node,
-					obj->size / PAGE_SIZE, 0);
-	if (!list->file_offset_node) {
-		ret = -ENOMEM;
-		goto free_it;
-	}
-	list->hash.key = list->file_offset_node->start;
-	ret = drm_ht_insert_item(&mm->offset_hash, &list->hash);
-	if (ret) {
-		DRM_ERROR("failed to add to map hash\n");
-		goto free_mm;
-	}
-	return 0;
-
-free_mm:
-	drm_mm_put_block(list->file_offset_node);
-free_it:
-	kfree(list->map);
-	list->map = NULL;
-	return ret;
-}
-
-/**
  *	psb_gem_dumb_map_gtt	-	buffer mapping for dumb interface
  *	@file: our drm client file
  *	@dev: drm device
@@ -142,7 +83,7 @@ int psb_gem_dumb_map_gtt(struct drm_file *file, struct drm_device *dev,
 	
 	/* Make it mmapable */
 	if (!obj->map_list.map) {
-		ret = psb_gem_create_mmap_offset(obj);
+		ret = drm_gem_create_mmap_offset(obj);
 		if (ret)
 			goto out;
 	}
-- 
1.7.4.1

  parent reply	other threads:[~2011-08-04 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19  0:20 [PATCH 0/3] RFC: Common functions for GEM offset creation Rob Clark
2011-07-19  0:20 ` [PATCH 1/3] drm/gem: add functions for mmap " Rob Clark
2011-07-19  0:20 ` [PATCH 2/3] drm/i915: use common " Rob Clark
2011-07-19  0:20 ` [PATCH 3/3] drm/gma500: " Rob Clark
2011-07-19  8:57 ` [PATCH 0/3] RFC: Common functions for GEM " Alan Cox
2011-07-19 13:01   ` Rob Clark
2011-07-19 16:00     ` Alan Cox
2011-07-19  9:33 ` Chris Wilson
2011-07-19 13:12   ` Rob Clark
2011-08-04 11:20     ` Rob Clark
2011-08-04 16:06       ` Daniel Vetter
2011-08-04 17:07 ` [PATCH 1/9] drm/gem: add functions for mmap " Rob Clark
2011-08-04 17:07 ` [PATCH 2/9] drm/i915: use common " Rob Clark
2011-08-04 17:07 ` Rob Clark [this message]
2011-08-10 12:39   ` [PATCH 3/9] drm/gma500: " Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312477672-32366-3-git-send-email-rob@ti.com \
    --to=rob@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=patches@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.