From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Rob Clark <rob@ti.com>
Subject: Re: [PATCH 0/3] RFC: Common functions for GEM offset creation
Date: Tue, 19 Jul 2011 10:33:35 +0100 [thread overview]
Message-ID: <e39f63$s9cit@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <cover.1311034363.git.rob@ti.com>
On Mon, 18 Jul 2011 19:20:56 -0500, Rob Clark <rob@ti.com> wrote:
> In the process of adding GEM support for OMAP DRM driver, I noticed that
> I was adding code for creating/freeing mmap offsets which was virtually
> identical to what was already duplicated in i915 and gma500 drivers.
>
> Rather than duplicating the code a 3rd time, it seemed like a good idea
> to move it to the GEM core.
>
> Note that I don't actually have a way to test psb or i915, but the
> changes seem straightforward enough.
My only concern is that for the common functions the mmap_offset to create
should be passed in a parameter, so that we could support more than one
mapping for an object.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-07-19 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 0:20 [PATCH 0/3] RFC: Common functions for GEM offset creation Rob Clark
2011-07-19 0:20 ` [PATCH 1/3] drm/gem: add functions for mmap " Rob Clark
2011-07-19 0:20 ` [PATCH 2/3] drm/i915: use common " Rob Clark
2011-07-19 0:20 ` [PATCH 3/3] drm/gma500: " Rob Clark
2011-07-19 8:57 ` [PATCH 0/3] RFC: Common functions for GEM " Alan Cox
2011-07-19 13:01 ` Rob Clark
2011-07-19 16:00 ` Alan Cox
2011-07-19 9:33 ` Chris Wilson [this message]
2011-07-19 13:12 ` Rob Clark
2011-08-04 11:20 ` Rob Clark
2011-08-04 16:06 ` Daniel Vetter
2011-08-04 17:07 ` [PATCH 1/9] drm/gem: add functions for mmap " Rob Clark
2011-08-04 17:07 ` [PATCH 2/9] drm/i915: use common " Rob Clark
2011-08-04 17:07 ` [PATCH 3/9] drm/gma500: " Rob Clark
2011-08-10 12:39 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e39f63$s9cit@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=rob@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.