* [PATCH] dmaengine: pl330: add missing include of scatterlist.h
@ 2011-08-08 19:14 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2011-08-08 19:14 UTC (permalink / raw)
To: linux-arm-kernel
From: Rob Herring <rob.herring@calxeda.com>
scatterlist.h was getting implicitly included and now is not which
causes this compile error:
drivers/dma/pl330.c: In function ?pl330_prep_slave_sg?:
drivers/dma/pl330.c:603:2: error: implicit declaration of function
?for_each_sg?
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Vinod Koul <vkoul@infradead.org>
---
drivers/dma/pl330.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 00eee59..4e2ccde 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -15,6 +15,7 @@
#include <linux/module.h>
#include <linux/dmaengine.h>
#include <linux/interrupt.h>
+#include <linux/scatterlist.h>
#include <linux/amba/bus.h>
#include <linux/amba/pl330.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dmaengine: pl330: add missing include of scatterlist.h
@ 2011-08-08 19:14 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2011-08-08 19:14 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel; +Cc: Rob Herring, Jassi Brar, Vinod Koul
From: Rob Herring <rob.herring@calxeda.com>
scatterlist.h was getting implicitly included and now is not which
causes this compile error:
drivers/dma/pl330.c: In function ‘pl330_prep_slave_sg’:
drivers/dma/pl330.c:603:2: error: implicit declaration of function
‘for_each_sg’
Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Vinod Koul <vkoul@infradead.org>
---
drivers/dma/pl330.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 00eee59..4e2ccde 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -15,6 +15,7 @@
#include <linux/module.h>
#include <linux/dmaengine.h>
#include <linux/interrupt.h>
+#include <linux/scatterlist.h>
#include <linux/amba/bus.h>
#include <linux/amba/pl330.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] dmaengine: pl330: add missing include of scatterlist.h
2011-08-08 19:14 ` Rob Herring
@ 2011-08-08 19:29 ` Jassi Brar
-1 siblings, 0 replies; 6+ messages in thread
From: Jassi Brar @ 2011-08-08 19:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 9, 2011 at 12:44 AM, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> scatterlist.h was getting implicitly included and now is not which
> causes this compile error:
>
> drivers/dma/pl330.c: In function ?pl330_prep_slave_sg?:
> drivers/dma/pl330.c:603:2: error: implicit declaration of function
> ?for_each_sg?
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: Vinod Koul <vkoul@infradead.org>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
thnx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dmaengine: pl330: add missing include of scatterlist.h
@ 2011-08-08 19:29 ` Jassi Brar
0 siblings, 0 replies; 6+ messages in thread
From: Jassi Brar @ 2011-08-08 19:29 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, linux-arm-kernel, Rob Herring, Vinod Koul
On Tue, Aug 9, 2011 at 12:44 AM, Rob Herring <robherring2@gmail.com> wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> scatterlist.h was getting implicitly included and now is not which
> causes this compile error:
>
> drivers/dma/pl330.c: In function ‘pl330_prep_slave_sg’:
> drivers/dma/pl330.c:603:2: error: implicit declaration of function
> ‘for_each_sg’
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Cc: Jassi Brar <jassisinghbrar@gmail.com>
> Cc: Vinod Koul <vkoul@infradead.org>
Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
thnx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] dmaengine: pl330: add missing include of scatterlist.h
2011-08-08 19:29 ` Jassi Brar
@ 2011-08-09 4:36 ` Koul, Vinod
-1 siblings, 0 replies; 6+ messages in thread
From: Koul, Vinod @ 2011-08-09 4:36 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2011-08-09 at 00:59 +0530, Jassi Brar wrote:
> On Tue, Aug 9, 2011 at 12:44 AM, Rob Herring <robherring2@gmail.com> wrote:
> > From: Rob Herring <rob.herring@calxeda.com>
> >
> > scatterlist.h was getting implicitly included and now is not which
> > causes this compile error:
> >
> > drivers/dma/pl330.c: In function ?pl330_prep_slave_sg?:
> > drivers/dma/pl330.c:603:2: error: implicit declaration of function
> > ?for_each_sg?
> >
> > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> > Cc: Jassi Brar <jassisinghbrar@gmail.com>
> > Cc: Vinod Koul <vkoul@infradead.org>
>
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
>
> thnx
Commit 90b44f8 introduces dmaengine_prep_slave_single API which adds
scatterlist.h in dmaengine.h, since you already include dmaengine.h this
patch shouldn't be required
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dmaengine: pl330: add missing include of scatterlist.h
@ 2011-08-09 4:36 ` Koul, Vinod
0 siblings, 0 replies; 6+ messages in thread
From: Koul, Vinod @ 2011-08-09 4:36 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel, linux-arm-kernel, Rob Herring, Jassi Brar
On Tue, 2011-08-09 at 00:59 +0530, Jassi Brar wrote:
> On Tue, Aug 9, 2011 at 12:44 AM, Rob Herring <robherring2@gmail.com> wrote:
> > From: Rob Herring <rob.herring@calxeda.com>
> >
> > scatterlist.h was getting implicitly included and now is not which
> > causes this compile error:
> >
> > drivers/dma/pl330.c: In function ‘pl330_prep_slave_sg’:
> > drivers/dma/pl330.c:603:2: error: implicit declaration of function
> > ‘for_each_sg’
> >
> > Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> > Cc: Jassi Brar <jassisinghbrar@gmail.com>
> > Cc: Vinod Koul <vkoul@infradead.org>
>
> Acked-by: Jassi Brar <jassisinghbrar@gmail.com>
>
> thnx
Commit 90b44f8 introduces dmaengine_prep_slave_single API which adds
scatterlist.h in dmaengine.h, since you already include dmaengine.h this
patch shouldn't be required
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-09 4:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-08 19:14 [PATCH] dmaengine: pl330: add missing include of scatterlist.h Rob Herring
2011-08-08 19:14 ` Rob Herring
2011-08-08 19:29 ` Jassi Brar
2011-08-08 19:29 ` Jassi Brar
2011-08-09 4:36 ` Koul, Vinod
2011-08-09 4:36 ` Koul, Vinod
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.