From: Joe Perches <joe@perches.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, stufever@gmail.com,
netdev@vger.kernel.org, davem@davemloft.net,
Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c
Date: Tue, 09 Aug 2011 11:12:25 -0700 [thread overview]
Message-ID: <1312913545.11924.16.camel@Joe-Laptop> (raw)
In-Reply-To: <1312912774.2547.1.camel@edumazet-laptop>
On Tue, 2011-08-09 at 19:59 +0200, Eric Dumazet wrote:
> Le mardi 09 août 2011 à 10:52 -0700, Joe Perches a écrit :
> > On Tue, 2011-08-09 at 18:53 +0200, Eric Dumazet wrote:
> > > Le mercredi 10 août 2011 à 00:39 +0800, stufever@gmail.com a écrit :
> > []
> > > > + if (!local_rqfpr || !local_rqfcr) {
> > > > + pr_err("Out of memory\n");
> > > Please remove this pr_err(), kmalloc() will complain already.
> > Always?
> > I know there's a trace option, but is it always on?
> Yes, unless caller added ___GFP_NOWARN in gfp :
> ptr = kmalloc(size, GFP_KERNEL | ___GFP_NOWARN);
Isn't that true only for slub?
Do you know where this get emitted?
I looked cursorily but I don't see it.
next prev parent reply other threads:[~2011-08-09 18:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 16:39 [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c stufever
2011-08-09 16:53 ` Eric Dumazet
2011-08-09 17:52 ` Joe Perches
2011-08-09 17:59 ` Eric Dumazet
2011-08-09 18:12 ` Joe Perches [this message]
2011-08-09 18:24 ` Eric Dumazet
2011-08-09 19:57 ` Joe Perches
2011-08-10 2:20 ` Wang Shaoyan
-- strict thread matches above, loose matches on Subject: below --
2011-08-10 4:06 stufever
2011-08-10 2:29 stufever
2011-08-10 2:28 ` Joe Perches
2011-08-10 3:50 ` Wang Shaoyan
2011-08-10 4:07 ` Joe Perches
2011-08-10 4:11 ` David Miller
2011-08-09 15:45 stufever
2011-08-09 15:50 ` David Miller
2011-08-09 16:06 ` Wang Shaoyan
2011-08-09 16:08 ` Joe Perches
2011-08-09 16:37 ` Wang Shaoyan
2011-08-09 15:18 stufever
2011-08-09 15:43 ` Eric Dumazet
2011-08-09 16:02 ` Wang Shaoyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312913545.11924.16.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stufever@gmail.com \
--cc=wangshaoyan.pt@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.