From: Joe Perches <joe@perches.com>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c
Date: Tue, 09 Aug 2011 19:28:36 -0700 [thread overview]
Message-ID: <1312943316.11924.54.camel@Joe-Laptop> (raw)
In-Reply-To: <1312943399-14435-1-git-send-email-wangshaoyan.pt@taobao.com>
On Wed, 2011-08-10 at 10:29 +0800, stufever@gmail.com wrote:
> Signed-off-by: Wang Shaoyan <wangshaoyan.pt@taobao.com>
[]
> diff --git a/drivers/net/gianfar_ethtool.c b/drivers/net/gianfar_ethtool.c
[]
> @@ -686,10 +686,21 @@ static int gfar_ethflow_to_filer_table(struct gfar_private *priv, u64 ethflow, u
[]
> + if (!local_rqfpr || !local_rqfcr) {
> + pr_err("Out of memory\n");
> + ret = 0;
> + got err;
"got err" is true.
Please compile test your patches before sending them.
next prev parent reply other threads:[~2011-08-10 2:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 2:29 [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c stufever
2011-08-10 2:28 ` Joe Perches [this message]
2011-08-10 3:50 ` Wang Shaoyan
2011-08-10 4:07 ` Joe Perches
2011-08-10 4:11 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2011-08-10 4:06 stufever
2011-08-09 16:39 stufever
2011-08-09 16:53 ` Eric Dumazet
2011-08-09 17:52 ` Joe Perches
2011-08-09 17:59 ` Eric Dumazet
2011-08-09 18:12 ` Joe Perches
2011-08-09 18:24 ` Eric Dumazet
2011-08-09 19:57 ` Joe Perches
2011-08-10 2:20 ` Wang Shaoyan
2011-08-09 15:45 stufever
2011-08-09 15:50 ` David Miller
2011-08-09 16:06 ` Wang Shaoyan
2011-08-09 16:08 ` Joe Perches
2011-08-09 16:37 ` Wang Shaoyan
2011-08-09 15:18 stufever
2011-08-09 15:43 ` Eric Dumazet
2011-08-09 16:02 ` Wang Shaoyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312943316.11924.54.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stufever@gmail.com \
--cc=wangshaoyan.pt@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.