From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
Date: Wed, 10 Aug 2011 18:56:25 +0000 [thread overview]
Message-ID: <1313002585.1674.13.camel@pasglop> (raw)
In-Reply-To: <4E429CAD.5050000@suse.de>
On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote:
> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
> > On a box with gcc 4.3.2, I see errors like:
> >
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
>
> Paul, mind to ack?
I merged it already :-) It was trivial & annoying enough.
Cheers,
Ben.
>
> Alex
>
> > Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
> > ---
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 6dd3358..de29501 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r6,reg*16+VCPU_VSRS
> > - stxvd2x reg,r6,r3
> > + STXVD2X(reg,r6,r3)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
> > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r7,reg*16+VCPU_VSRS
> > - lxvd2x reg,r7,r4
> > + LXVD2X(reg,r7,r4)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
Paul Mackerras <paulus@samba.org>, Avi Kivity <avi@redhat.com>,
Nishanth Aravamudan <nacc@us.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
Date: Wed, 10 Aug 2011 13:56:25 -0500 [thread overview]
Message-ID: <1313002585.1674.13.camel@pasglop> (raw)
In-Reply-To: <4E429CAD.5050000@suse.de>
On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote:
> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
> > On a box with gcc 4.3.2, I see errors like:
> >
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
>
> Paul, mind to ack?
I merged it already :-) It was trivial & annoying enough.
Cheers,
Ben.
>
> Alex
>
> > Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
> > ---
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 6dd3358..de29501 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r6,reg*16+VCPU_VSRS
> > - stxvd2x reg,r6,r3
> > + STXVD2X(reg,r6,r3)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
> > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r7,reg*16+VCPU_VSRS
> > - lxvd2x reg,r7,r4
> > + LXVD2X(reg,r7,r4)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: Nishanth Aravamudan <nacc@us.ibm.com>,
Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Paul Mackerras <paulus@samba.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
Date: Wed, 10 Aug 2011 13:56:25 -0500 [thread overview]
Message-ID: <1313002585.1674.13.camel@pasglop> (raw)
In-Reply-To: <4E429CAD.5050000@suse.de>
On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote:
> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
> > On a box with gcc 4.3.2, I see errors like:
> >
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
>
> Paul, mind to ack?
I merged it already :-) It was trivial & annoying enough.
Cheers,
Ben.
>
> Alex
>
> > Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
> > ---
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 6dd3358..de29501 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r6,reg*16+VCPU_VSRS
> > - stxvd2x reg,r6,r3
> > + STXVD2X(reg,r6,r3)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
> > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r7,reg*16+VCPU_VSRS
> > - lxvd2x reg,r7,r4
> > + LXVD2X(reg,r7,r4)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-10 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 18:55 [PATCH] powerpc/kvm: fix build errors with older toolchains Nishanth Aravamudan
2011-08-03 18:55 ` Nishanth Aravamudan
2011-08-03 18:55 ` Nishanth Aravamudan
2011-08-10 14:58 ` Alexander Graf
2011-08-10 14:58 ` Alexander Graf
2011-08-10 14:58 ` Alexander Graf
2011-08-10 18:56 ` Benjamin Herrenschmidt [this message]
2011-08-10 18:56 ` Benjamin Herrenschmidt
2011-08-10 18:56 ` Benjamin Herrenschmidt
2011-08-10 21:46 ` Alexander Graf
2011-08-10 21:46 ` Alexander Graf
2011-08-10 21:46 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313002585.1674.13.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mtosatti@redhat.com \
--cc=nacc@us.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.