From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p)
Date: Fri, 26 Aug 2011 10:59:56 +0200 [thread overview]
Message-ID: <1314349196.26922.22.camel@twins> (raw)
In-Reply-To: <1314346676.6486.25.camel@minggr.sh.intel.com>
On Fri, 2011-08-26 at 16:17 +0800, Lin Ming wrote:
> @@ -292,7 +292,7 @@ static unsigned int bm_bit_to_page_idx(struct drbd_bitmap *b, u64 bitnr)
> static unsigned long *__bm_map_pidx(struct drbd_bitmap *b, unsigned int idx, const enum km_type km)
> {
> struct page *page = b->bm_pages[idx];
> - return (unsigned long *) kmap_atomic(page, km);
> + return (unsigned long *) kmap_atomic(page);
> }
>
> static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
> @@ -302,7 +302,7 @@ static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
>
> static void __bm_unmap(unsigned long *p_addr, const enum km_type km)
> {
> - kunmap_atomic(p_addr, km);
> + kunmap_atomic(p_addr);
> };
>
Stuff like that is really only a half-assed cleanup, IIRC there's more
sites like that.
In my initial massive patch I cleaned all that up as well.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p)
Date: Fri, 26 Aug 2011 10:59:56 +0200 [thread overview]
Message-ID: <1314349196.26922.22.camel@twins> (raw)
In-Reply-To: <1314346676.6486.25.camel@minggr.sh.intel.com>
On Fri, 2011-08-26 at 16:17 +0800, Lin Ming wrote:
> @@ -292,7 +292,7 @@ static unsigned int bm_bit_to_page_idx(struct drbd_bitmap *b, u64 bitnr)
> static unsigned long *__bm_map_pidx(struct drbd_bitmap *b, unsigned int idx, const enum km_type km)
> {
> struct page *page = b->bm_pages[idx];
> - return (unsigned long *) kmap_atomic(page, km);
> + return (unsigned long *) kmap_atomic(page);
> }
>
> static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
> @@ -302,7 +302,7 @@ static unsigned long *bm_map_pidx(struct drbd_bitmap *b, unsigned int idx)
>
> static void __bm_unmap(unsigned long *p_addr, const enum km_type km)
> {
> - kunmap_atomic(p_addr, km);
> + kunmap_atomic(p_addr);
> };
>
Stuff like that is really only a half-assed cleanup, IIRC there's more
sites like that.
In my initial massive patch I cleaned all that up as well.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-26 9:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 8:17 [PATCH 1/2] mm: convert k{un}map_atomic(p, KM_type) to k{un}map_atomic(p) Lin Ming
2011-08-26 8:17 ` Lin Ming
2011-08-26 8:58 ` Peter Zijlstra
2011-08-26 8:58 ` Peter Zijlstra
2011-08-26 19:42 ` Andrew Morton
2011-08-26 19:42 ` Andrew Morton
2011-08-26 20:40 ` Nick Bowler
2011-08-26 20:40 ` Nick Bowler
2011-08-29 12:33 ` Peter Zijlstra
2011-08-29 12:33 ` Peter Zijlstra
2011-08-29 12:27 ` Peter Zijlstra
2011-08-29 12:27 ` Peter Zijlstra
2011-08-29 12:27 ` [Drbd-dev] " Peter Zijlstra
2011-08-29 12:27 ` Peter Zijlstra
2011-08-26 8:59 ` Peter Zijlstra [this message]
2011-08-26 8:59 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314349196.26922.22.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ming.m.lin@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.