From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dan Carpenter <error27@gmail.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"open list:INTEL WIRELESS WI..." <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch -next 1/2] iwlwifi: fix double assign in
Date: Wed, 31 Aug 2011 09:34:29 +0000 [thread overview]
Message-ID: <1314783269.26890.3.camel@wwguy-huron> (raw)
In-Reply-To: <1314772887.4161.17.camel@jlt3.sipsolutions.net>
On Tue, 2011-08-30 at 23:41 -0700, Johannes Berg wrote:
> On Wed, 2011-08-31 at 09:37 +0300, Dan Carpenter wrote:
> > "vif" is assigned twice. We can remove the first one.
> >
> > This silences a Smatch warning that "ctx" could be one step past the
> > end of the priv->contexts[] array.
>
> Good catch.
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
>
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> >
Thanks
Wey
WARNING: multiple messages have this Message-ID (diff)
From: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Dan Carpenter <error27@gmail.com>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
"open list:INTEL WIRELESS WI..." <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch -next 1/2] iwlwifi: fix double assign in iwl_start_tx_ba_trans_ready()
Date: Wed, 31 Aug 2011 02:34:29 -0700 [thread overview]
Message-ID: <1314783269.26890.3.camel@wwguy-huron> (raw)
In-Reply-To: <1314772887.4161.17.camel@jlt3.sipsolutions.net>
On Tue, 2011-08-30 at 23:41 -0700, Johannes Berg wrote:
> On Wed, 2011-08-31 at 09:37 +0300, Dan Carpenter wrote:
> > "vif" is assigned twice. We can remove the first one.
> >
> > This silences a Smatch warning that "ctx" could be one step past the
> > end of the priv->contexts[] array.
>
> Good catch.
>
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
>
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> >
Thanks
Wey
next prev parent reply other threads:[~2011-08-31 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 6:37 [patch -next 1/2] iwlwifi: fix double assign in Dan Carpenter
2011-08-31 6:37 ` [patch -next 1/2] iwlwifi: fix double assign in iwl_start_tx_ba_trans_ready() Dan Carpenter
2011-08-31 6:41 ` [patch -next 1/2] iwlwifi: fix double assign in Johannes Berg
2011-08-31 6:41 ` [patch -next 1/2] iwlwifi: fix double assign in iwl_start_tx_ba_trans_ready() Johannes Berg
2011-08-31 9:34 ` Guy, Wey-Yi [this message]
2011-08-31 9:34 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314783269.26890.3.camel@wwguy-huron \
--to=wey-yi.w.guy@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=error27@gmail.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.