From: Dan McGee <dpmcgee@gmail.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH 0/5 v2] pata_sis fixes and driver cleanup
Date: Wed, 7 Sep 2011 11:23:17 -0500 [thread overview]
Message-ID: <1315412602-6560-1-git-send-email-dpmcgee@gmail.com> (raw)
This started as just two patches to use the correct UDMA 100 timings on
chipsets not supporting UDMA 133 but has grown a bit. This resubmit fixes the
following issues, much of them pointed out by Sergei Shtylyov:
* Ensure 0xC0 is used to mask, not 0xE0
* Move all 'static const' changes to separate patch
* Formatting cleanups- don't introduce new formatting issues, and add a patch
to fix existing ones
* Comment referred to bit 14, but it is bit 30 as we grab a word, not two bytes
* Use dev_info(), not printk() directly
* Adjust commit message to include old commit summary
The first two patches are the critical ones that fix a regression between the
old IDE stack and the new (P)ATA one.
Dan McGee (5):
pata_sis: extract a sis_port_base() method
pata_sis: add mode_filter method for certain sis5513 chipsets
pata_sis: enable MWDMA for UDMA 133 chipset
pata_sis: mark most const data static as well
pata_sis: code style cleanups for consistency
drivers/ata/pata_sis.c | 154 +++++++++++++++++++++++++++++++-----------------
1 files changed, 99 insertions(+), 55 deletions(-)
$ python2 scripts/bloat-o-meter pata_sis.ko.old drivers/ata/pata_sis.ko
add/remove: 8/0 grow/shrink: 5/6 up/down: 313/-251 (62)
function old new delta
static.sis_port_base - 83 +83
sis_133_mode_filter - 82 +82
static.udma_bits 7 31 +24
sis_init_one 695 719 +24
static.timing133 - 20 +20
static.timing100 - 20 +20
static.timing_u133 28 40 +12
static.timing_u100 28 40 +12
static.mwdma_bits - 12 +12
sis_133_set_dmamode 195 204 +9
static.recovery - 5 +5
static.actrec - 5 +5
static.active - 5 +5
sis_100_set_piomode 129 111 -18
sis_old_set_dmamode 192 171 -21
sis_100_set_dmamode 156 134 -22
sis_old_set_piomode 229 193 -36
sis_66_set_dmamode 216 171 -45
sis_133_set_piomode 265 156 -109
$ size pata_sis.ko.old drivers/ata/pata_sis.ko
text data bss dec hex filename
4524 2724 4 7252 1c54 pata_sis.ko.old
4649 2724 4 7377 1cd1 drivers/ata/pata_sis.ko
--
1.7.6.1
next reply other threads:[~2011-09-07 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 16:23 Dan McGee [this message]
2011-09-07 16:23 ` [PATCH 1/5] pata_sis: extract a sis_port_base() method Dan McGee
2011-09-07 16:23 ` [PATCH 2/5] pata_sis: add mode_filter method for certain sis5513 chipsets Dan McGee
2011-09-07 16:23 ` [PATCH 3/5] pata_sis: enable MWDMA for UDMA 133 chipset Dan McGee
2011-09-07 16:23 ` [PATCH 4/5] pata_sis: mark most const data static as well Dan McGee
2011-09-07 16:23 ` [PATCH 5/5] pata_sis: code style cleanups for consistency Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315412602-6560-1-git-send-email-dpmcgee@gmail.com \
--to=dpmcgee@gmail.com \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.