All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Russell King <rmk+kernel@arm.linux.org.uk>
Subject: [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure
Date: Wed, 14 Sep 2011 17:18:13 +0800	[thread overview]
Message-ID: <1315991893.17271.2.camel@phoenix> (raw)

Hi,

I got below build error: ( on linux-next 20110831 )
  CC      sound/soc/samsung/neo1973_wm8753.o
sound/soc/samsung/neo1973_wm8753.c: In function 'neo1973_wm8753_init':
sound/soc/samsung/neo1973_wm8753.c:325: error: implicit declaration of function 'machine_is_neo1973_gta01'
make[3]: *** [sound/soc/samsung/neo1973_wm8753.o] Error 1
make[2]: *** [sound/soc/samsung] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2

I think the root cause is below commit:
commit 6f82f4db "ARM: Update (and cut down) mach-types"
removes neo1973_gta01 entry.

I'm not sure if we should add back the neo1973_gta01 entry to mach-types or
remove all machine_is_neo1973_gta01() calls in neo1973_wm8753.c.
Comments?

Regards,
Axel

             reply	other threads:[~2011-09-14  9:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  9:18 Axel Lin [this message]
2011-09-14 19:19 ` [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure Russell King
2011-09-14 23:28   ` Mark Brown
2011-09-14 23:28     ` Mark Brown
2011-09-14 23:38     ` Russell King
2011-09-15  9:46       ` Mark Brown
2011-09-15 11:00         ` Russell King
2011-09-15 11:53           ` Lars-Peter Clausen
2011-09-15 11:53             ` Lars-Peter Clausen
2011-09-15 12:06             ` Russell King
2011-09-16 17:02             ` Valdis.Kletnieks
2011-09-16 17:02               ` Valdis.Kletnieks
2011-09-16 20:03               ` Russell King
2011-09-15 13:31           ` Mark Brown
2011-09-15 13:31             ` Mark Brown
2011-09-15 19:16             ` Russell King
2011-09-15 22:39               ` Mark Brown
2011-09-15 22:39                 ` Mark Brown
2011-09-15  7:20   ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315991893.17271.2.camel@phoenix \
    --to=axel.lin@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.