All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Russell King <rmk+alsa@arm.linux.org.uk>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org, Axel Lin <axel.lin@gmail.com>,
	Liam Girdwood <lrg@ti.com>, Harald Welte <laforge@openezx.org>
Subject: Re: [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure
Date: Thu, 15 Sep 2011 13:53:04 +0200	[thread overview]
Message-ID: <4E71E720.7040008@metafoo.de> (raw)
In-Reply-To: <20110915110056.GA32615@flint.arm.linux.org.uk>

On 09/15/2011 01:00 PM, Russell King wrote:
> [...]
> We now have a sane policy: entries which aren't fully up to date are
> automatically dropped.  Entries for which there is no platform support
> file merged within 12 months of the entries last edit are dropped also
> automatically dropped.

Partly unrelated, but what about these platforms which can be fully described
with DT and don't need a platform file?

> [...]
> Lastly, GTA01 board support was added to the ALSA stuff in 2008 without
> the main platform support in arch/arm - so it can't be usefully used.
> It's been three years since that was done and still there is no sign of
> the main platform support appearing.  It's been five years since the
> entry was created in the machine database.
> 
> Face it, GTA01 is dead as far as mainline is concerned.
> 
> If it's not dead then it needs sorting out.  Either way there's two
> valid states:  1. fully merged, or 2. none of it is merged.
> There's no real half-way house state - certainly not one which should
> persist for three years.  (It would be reasonable for maybe a couple
> of kernel releases but more than that is becoming very much a joke.)

The code for GTA01 is out there and could be merged into mainline, but I think
it would be dead code since there doesn't seem to be really any interest in the
device anymore.

So just get rid of the gta01 portions of the neo1973_wm8753 driver. If GTA01
support ever gets merged we can still revert the removal.

- Lars

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Russell King <rmk+alsa@arm.linux.org.uk>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Axel Lin <axel.lin@gmail.com>, Harald Welte <laforge@openezx.org>,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Liam Girdwood <lrg@ti.com>
Subject: Re: [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure
Date: Thu, 15 Sep 2011 13:53:04 +0200	[thread overview]
Message-ID: <4E71E720.7040008@metafoo.de> (raw)
In-Reply-To: <20110915110056.GA32615@flint.arm.linux.org.uk>

On 09/15/2011 01:00 PM, Russell King wrote:
> [...]
> We now have a sane policy: entries which aren't fully up to date are
> automatically dropped.  Entries for which there is no platform support
> file merged within 12 months of the entries last edit are dropped also
> automatically dropped.

Partly unrelated, but what about these platforms which can be fully described
with DT and don't need a platform file?

> [...]
> Lastly, GTA01 board support was added to the ALSA stuff in 2008 without
> the main platform support in arch/arm - so it can't be usefully used.
> It's been three years since that was done and still there is no sign of
> the main platform support appearing.  It's been five years since the
> entry was created in the machine database.
> 
> Face it, GTA01 is dead as far as mainline is concerned.
> 
> If it's not dead then it needs sorting out.  Either way there's two
> valid states:  1. fully merged, or 2. none of it is merged.
> There's no real half-way house state - certainly not one which should
> persist for three years.  (It would be reasonable for maybe a couple
> of kernel releases but more than that is becoming very much a joke.)

The code for GTA01 is out there and could be merged into mainline, but I think
it would be dead code since there doesn't seem to be really any interest in the
device anymore.

So just get rid of the gta01 portions of the neo1973_wm8753 driver. If GTA01
support ever gets merged we can still revert the removal.

- Lars

  reply	other threads:[~2011-09-15 11:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  9:18 [linux-next] ASoC: sound/soc/samsung/neo1973_wm8753.c build failure Axel Lin
2011-09-14 19:19 ` Russell King
2011-09-14 23:28   ` Mark Brown
2011-09-14 23:28     ` Mark Brown
2011-09-14 23:38     ` Russell King
2011-09-15  9:46       ` Mark Brown
2011-09-15 11:00         ` Russell King
2011-09-15 11:53           ` Lars-Peter Clausen [this message]
2011-09-15 11:53             ` Lars-Peter Clausen
2011-09-15 12:06             ` Russell King
2011-09-16 17:02             ` Valdis.Kletnieks
2011-09-16 17:02               ` Valdis.Kletnieks
2011-09-16 20:03               ` Russell King
2011-09-15 13:31           ` Mark Brown
2011-09-15 13:31             ` Mark Brown
2011-09-15 19:16             ` Russell King
2011-09-15 22:39               ` Mark Brown
2011-09-15 22:39                 ` Mark Brown
2011-09-15  7:20   ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E71E720.7040008@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=axel.lin@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=laforge@openezx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=rmk+alsa@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.