From: Liam Girdwood <lrg@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: wm8995: Return -EINVAL if device ID mismatch
Date: Fri, 16 Sep 2011 10:28:20 +0100 [thread overview]
Message-ID: <1316165300.3229.8.camel@odin> (raw)
In-Reply-To: <1316141193.21890.1.camel@phoenix>
On Fri, 2011-09-16 at 10:46 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/wm8995.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c
> index 5ad873f..05f7795 100644
> --- a/sound/soc/codecs/wm8995.c
> +++ b/sound/soc/codecs/wm8995.c
> @@ -1642,6 +1642,7 @@ static int wm8995_probe(struct snd_soc_codec *codec)
>
> if (ret != 0x8995) {
> dev_err(codec->dev, "Invalid device ID: %#x\n", ret);
> + ret = -EINVAL;
> goto err_reg_enable;
> }
>
Both
Acked-by: Liam Girdwood <lrg@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@ti.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: wm8995: Return -EINVAL if device ID mismatch
Date: Fri, 16 Sep 2011 10:28:20 +0100 [thread overview]
Message-ID: <1316165300.3229.8.camel@odin> (raw)
In-Reply-To: <1316141193.21890.1.camel@phoenix>
On Fri, 2011-09-16 at 10:46 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/wm8995.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8995.c b/sound/soc/codecs/wm8995.c
> index 5ad873f..05f7795 100644
> --- a/sound/soc/codecs/wm8995.c
> +++ b/sound/soc/codecs/wm8995.c
> @@ -1642,6 +1642,7 @@ static int wm8995_probe(struct snd_soc_codec *codec)
>
> if (ret != 0x8995) {
> dev_err(codec->dev, "Invalid device ID: %#x\n", ret);
> + ret = -EINVAL;
> goto err_reg_enable;
> }
>
Both
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-09-16 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 2:46 [PATCH 1/2] ASoC: wm8995: Return -EINVAL if device ID mismatch Axel Lin
2011-09-16 2:47 ` [PATCH 2/2] ASoC: wm8995: Remove unused i2c variable in wm8995_remove() Axel Lin
2011-09-16 9:28 ` Liam Girdwood [this message]
2011-09-16 9:28 ` [PATCH 1/2] ASoC: wm8995: Return -EINVAL if device ID mismatch Liam Girdwood
2011-09-16 9:49 ` Mark Brown
2011-09-16 9:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316165300.3229.8.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.