[PATCH 0/1] Quieten wet fetchers checkstatus method

[PATCH 0/1] Quieten wet fetchers checkstatus method

[Joshua Lock]

This patch ensures that the checkstatus() method of the wget fetcher calls runfetchcmd() in
quiet mode which prevents wget's noisy stdout being printed to the users console.

Regards,
Joshua

The following changes since commit f4be83aae77a713e2b5a2d094651639b6e641031:

  hob: correctly set the selected image when loading a recipe (2011-09-13 08:30:49 -0700)

are available in the git repository at:
  git://github.com/incandescant/bitbake sanity
  https://github.com/incandescant/bitbake/tree/sanity

Joshua Lock (1):
  fetch2/wget: make checkstatus() quieter

 lib/bb/fetch2/wget.py |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

-- 
1.7.6

[PATCH 1/1] fetch2/wget: make checkstatus() quieter

[Joshua Lock]

Change the wget fetcher to not emit the commands output when calling checkstatus, this
matches the behaviour of the git fetchers checkstatus() method.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 lib/bb/fetch2/wget.py |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py
index 7bd027a..d3be069 100644
--- a/lib/bb/fetch2/wget.py
+++ b/lib/bb/fetch2/wget.py
@@ -69,10 +69,11 @@ class Wget(FetchMethod):
 
             fetchcmd = fetchcmd.replace("${URI}", uri.split(";")[0])
             fetchcmd = fetchcmd.replace("${FILE}", ud.basename)
-            logger.info("fetch " + uri)
-            logger.debug(2, "executing " + fetchcmd)
+            if not checkonly:
+                logger.info("fetch " + uri)
+                logger.debug(2, "executing " + fetchcmd)
             bb.fetch2.check_network_access(d, fetchcmd)
-            runfetchcmd(fetchcmd, d)
+            runfetchcmd(fetchcmd, d, quiet=checkonly)
 
             # Sanity check since wget can pretend it succeed when it didn't
             # Also, this used to happen if sourceforge sent us to the mirror page
-- 
1.7.6

Re: [PATCH 1/1] fetch2/wget: make checkstatus() quieter

[Richard Purdie]

On Wed, 2011-09-14 at 15:40 -0700, Joshua Lock wrote:
> Change the wget fetcher to not emit the commands output when calling checkstatus, this
> matches the behaviour of the git fetchers checkstatus() method.
> 
> Signed-off-by: Joshua Lock <josh@linux.intel.com>
> ---
>  lib/bb/fetch2/wget.py |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)

Merged to master, thanks.

Richard