From: Laura Abbott <lauraa@codeaurora.org>
To: linux@arm.linux.org.uk, catalin.marinas@arm.com
Cc: Laura Abbott <lauraa@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Add unwinding annotations for 64bit division functions
Date: Mon, 19 Sep 2011 15:11:37 -0700 [thread overview]
Message-ID: <1316470297-5063-1-git-send-email-lauraa@codeaurora.org> (raw)
The 64bit division functions never had unwinding annotations
added. This prevents a backtrace from being printed within
the function and if a division by 0 occurs. Add the annotations.
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
arch/arm/lib/div64.S | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/div64.S b/arch/arm/lib/div64.S
index faa7748..e55c484 100644
--- a/arch/arm/lib/div64.S
+++ b/arch/arm/lib/div64.S
@@ -13,6 +13,7 @@
*/
#include <linux/linkage.h>
+#include <asm/unwind.h>
#ifdef __ARMEB__
#define xh r0
@@ -44,6 +45,7 @@
*/
ENTRY(__do_div64)
+UNWIND(.fnstart)
@ Test for easy paths first.
subs ip, r4, #1
@@ -189,7 +191,12 @@ ENTRY(__do_div64)
moveq yh, xh
moveq xh, #0
moveq pc, lr
+UNWIND(.fnend)
+UNWIND(.fnstart)
+UNWIND(.pad #4)
+UNWIND(.save {lr})
+Ldiv0_64:
@ Division by 0:
str lr, [sp, #-8]!
bl __div0
@@ -200,4 +207,5 @@ ENTRY(__do_div64)
mov xh, #0
ldr pc, [sp], #8
+UNWIND(.fnend)
ENDPROC(__do_div64)
--
1.7.3.3
WARNING: multiple messages have this Message-ID (diff)
From: lauraa@codeaurora.org (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Add unwinding annotations for 64bit division functions
Date: Mon, 19 Sep 2011 15:11:37 -0700 [thread overview]
Message-ID: <1316470297-5063-1-git-send-email-lauraa@codeaurora.org> (raw)
The 64bit division functions never had unwinding annotations
added. This prevents a backtrace from being printed within
the function and if a division by 0 occurs. Add the annotations.
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
arch/arm/lib/div64.S | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/lib/div64.S b/arch/arm/lib/div64.S
index faa7748..e55c484 100644
--- a/arch/arm/lib/div64.S
+++ b/arch/arm/lib/div64.S
@@ -13,6 +13,7 @@
*/
#include <linux/linkage.h>
+#include <asm/unwind.h>
#ifdef __ARMEB__
#define xh r0
@@ -44,6 +45,7 @@
*/
ENTRY(__do_div64)
+UNWIND(.fnstart)
@ Test for easy paths first.
subs ip, r4, #1
@@ -189,7 +191,12 @@ ENTRY(__do_div64)
moveq yh, xh
moveq xh, #0
moveq pc, lr
+UNWIND(.fnend)
+UNWIND(.fnstart)
+UNWIND(.pad #4)
+UNWIND(.save {lr})
+Ldiv0_64:
@ Division by 0:
str lr, [sp, #-8]!
bl __div0
@@ -200,4 +207,5 @@ ENTRY(__do_div64)
mov xh, #0
ldr pc, [sp], #8
+UNWIND(.fnend)
ENDPROC(__do_div64)
--
1.7.3.3
next reply other threads:[~2011-09-19 22:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 22:11 Laura Abbott [this message]
2011-09-19 22:11 ` [PATCH] arm: Add unwinding annotations for 64bit division functions Laura Abbott
2011-09-19 23:22 ` Nicolas Pitre
2011-09-19 23:22 ` Nicolas Pitre
2011-09-20 1:55 ` Laura Abbott
2011-09-20 1:55 ` Laura Abbott
2011-09-20 1:55 ` Laura Abbott
2011-09-20 13:27 ` Nicolas Pitre
2011-09-20 13:27 ` Nicolas Pitre
2011-09-20 14:57 ` Catalin Marinas
2011-09-20 14:57 ` Catalin Marinas
2011-09-21 11:39 ` Dave Martin
2011-09-21 11:39 ` Dave Martin
2011-09-21 11:55 ` Russell King - ARM Linux
2011-09-21 11:55 ` Russell King - ARM Linux
2011-09-21 13:33 ` Dave Martin
2011-09-21 13:33 ` Dave Martin
2011-09-22 7:28 ` Jon Medhurst (Tixy)
2011-09-22 7:28 ` Jon Medhurst (Tixy)
2011-09-22 9:48 ` Catalin Marinas
2011-09-22 9:48 ` Catalin Marinas
2011-09-22 11:06 ` Jon Medhurst (Tixy)
2011-09-22 11:06 ` Jon Medhurst (Tixy)
2011-09-22 11:57 ` Catalin Marinas
2011-09-22 11:57 ` Catalin Marinas
2011-09-22 12:13 ` Jon Medhurst (Tixy)
2011-09-22 12:13 ` Jon Medhurst (Tixy)
2011-09-22 13:00 ` Catalin Marinas
2011-09-22 13:00 ` Catalin Marinas
2011-09-22 13:19 ` Jon Medhurst (Tixy)
2011-09-22 13:19 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316470297-5063-1-git-send-email-lauraa@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.